Closed Bug 1783868 Opened 2 years ago Closed 2 years ago

[Independent Voices] Findbar checkbox labels lack contrast / look disabled with "Balanced" colorways

Categories

(Firefox :: Theme, defect, P2)

defect
Points:
1

Tracking

()

VERIFIED FIXED
105 Branch
Tracking Status
firefox-esr91 --- wontfix
firefox-esr102 --- wontfix
firefox103 --- wontfix
firefox104 --- wontfix
firefox105 --- verified
firefox106 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Regression)

Details

(Keywords: access, regression, Whiteboard: [fidefe-colorway-closet])

Attachments

(5 files)

This is something I noticed with the "Independent Voices" colorway collection; we use the toolbar color at 70% opacity, and that's not new behavior, it goes back to Proton, but it's problematic and especially obvious with themes that have a toolbar background that's not very light or dark (e.g. "Balanced" colorways), and are as such more prone to producing subpar contrast with the text color.

Attachment #9289032 - Attachment description: Screenshot from 2022-08-09 15-53-33.png → "Visionary — Balanced" with current reduced opacity

Here's how "Visionary — Balanced" would look with the opacity reduction removed. This would be my proposed solution here.

I have no insight as to why the opacity was reduced in the first place (although I reviewed that patch). Things like these weren't really explained when Proton was developed. It's not like the find bar is permanently visible, and when the user has explicitly opened it, I don't understand why we'd want to tune it down rather than drawing attention to it.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attached image "Light" with full opacity (deleted) —
Attached image "Dark" with full opacity (deleted) —
Keywords: regression
Regressed by: 1703043
Summary: [Independent Voices] Findbar text lacks contrast with "Balanced" colorways, looks disabled → [Independent Voices] Findbar checkbox labels lack contrast / look disabled with "Balanced" colorways

Set release status flags based on info from the regressing bug 1703043

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5aabf1d7d378 Stop reducing the opacity of findbar labels. r=Gijs
Regressions: 1784262
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
No longer regressions: 1784262
Flags: qe-verify+

Managed to reproduce the issue on Nightly from 2022-08-09.
Verified the fix using latest Nightly 106.0a1 and Nightly 105.0a1 (after the fix) on macOS 12.3, Ubuntu 18.04 x64 and Windows 10 x 64 and I can't seem to reproduce the issue anymore.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Duplicate of this bug: 1717429
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: