Closed Bug 178401 Opened 22 years ago Closed 20 years ago

Changing screenshots of themes in preferences.

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fredbezies, Assigned: shliang)

References

Details

(Keywords: classic, modern)

Attachments

(4 files, 4 obsolete files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021105 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021105 Since 1.2 beta, there is no more little button on the left to collapse toolbar. But in preference panel, in Apparence/themes, this little button is still "alive". Why not making new shots with "right" view ? Reproducible: Always Steps to Reproduce: Just go to Preferences/Apparence/Theme Actual Results: "Wrong" view of toolbars Expected Results: Toolbars with right view.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached image new preview for modern theme (obsolete) (deleted) —
New version of preview for modern theme. Just my 2 cents for mozilla :-)
Attached image New preview for classic theme (obsolete) (deleted) —
And here is preview for classic theme. Hope I helped :-)
Shots to replace - if you want to - preview.gif in /mozilla/themes/modern/global and /mozilla/themes/classic/global Hope I helped :-)
-> Themes
Assignee: ben → shliang
Component: Skinability → Themes
err. classic will look different in w2k, wXP, on linux and on macos (at the very least). the modern preview looks right
Assignee: shliang → jaggernaut
Keywords: classic, modern
-> owner
Assignee: jaggernaut → shliang
In answer to comment #5 : Well, if modern screenshot should be useful ;-)
The last update of the preview images was bug 135975. It contains some useful info about style (making sure all the buttons are active, not showing menus etc.) and the different versions of Classic on Windows, Mac OS 8/9 and X and Linux etc. CC'ing Greg Valure, who fixed bug 135975.
A little image editing should suffice, since it's a small change...
Attachment #105191 - Attachment is obsolete: true
Attachment #105190 - Attachment is obsolete: true
Attached image Updated themes/classic/global/mac/preview.gif (obsolete) (deleted) —
Can't forget Mac. You're on your own for getting these reviewed and checked in.
Severity: enhancement → minor
OS: Windows XP → All
Hardware: PC → All
Since Mac Classic is becoming a port, while you're at it you can switch the Mac preview to the OS X one and close bug 134670 at the same time.
Attachment #105219 - Attachment is obsolete: true
*** Bug 134670 has been marked as a duplicate of this bug. ***
As grippies (sigh) are back, this bug can be considered as invalid, isn't it ? Besides MacOS-X preview screenshot, of course ;-)
Updated to actual appearance of Mozilla 1.7rc1 on Mac OS X 10.3
Attachment #147973 - Flags: review?
Comment on attachment 147973 [details] Updated themes/classic/global/mac/preview.gif (for Panther) I see one problem with this image: It includes a web site icon/favicon (the read dragon head) while the shots of the Modern theme and the Classic theme for other platforms shows the default icon inside the Location Bar. Brion: Could you provide an image with the default icon, please? Thanks! Also when you want to ask for review you have to enter the email-adress of a reviewer into the textbox "Requestee". I'm cancelling the meaningless review request for now (instead of adding a reviewer email address) because of the Location Bar icon issue.
Attachment #147973 - Flags: review?
Swapped favicon for the default icon as per comment #16.
Attachment #147973 - Attachment is obsolete: true
Comment on attachment 154235 [details] Updated themes/classic/global/mac/preview.gif (for Panther; icon fixed) Jag, can you r or r/sr this shot? The current preview.gif still shows Classic on Mac OS 9.
Attachment #154235 - Flags: review?(jag)
Comment on attachment 154235 [details] Updated themes/classic/global/mac/preview.gif (for Panther; icon fixed) r+sr=jag
Attachment #154235 - Flags: superreview+
Attachment #154235 - Flags: review?(jag)
Attachment #154235 - Flags: review+
Updated image checked in. Thanks Brion! :-) Marking FIXED. (the checkin really fixed bug 134670 which was incorrectly marked as a dupe of this bug. This bug should have been marked INVALID when the grippies returned. Correcting all this now would only add to the confusion, so I'll let just rest these bugs in peace.)
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: