support inline functions in webapp
Categories
(Socorro :: Webapp, enhancement, P2)
Tracking
(Not tracked)
People
(Reporter: willkg, Assigned: willkg)
References
Details
Attachments
(2 files)
Debug sym files can have inline function information. When we update the stackwalker (bug #1779630), then the stackwalker will be outputting inline function information.
This bug covers figuring out what changes we need to make in the Socorro processor and webapp and making them or spinning off new bugs.
It's probably something along the lines of:
- add the relevant bits to the processed crash schema
- figure out how to display inline function information in the crashing thread stack in the Crash Stats report view
- figure out whether we want to factor inline function information into signature generation
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
See Markus' suggested mockups: https://bugzilla.mozilla.org/show_bug.cgi?id=1398533
Assignee | ||
Comment 2•2 years ago
|
||
I used Markus' patch and did a try build:
I used that build to create a crash report:
https://crash-stats.mozilla.org/report/index/20aec939-4154-4520-ba3c-024930220902
I'll use that to implement this with.
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Comment 4•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
This got pushed to prod in bug #1789701. I told Markus about it. He mentioned that when he asked on #crashreporting-wg, people preferred the other mockup.
mstange: when I asked for opinions on this channel, two or three people said the preferred separate rows for each inline, with "trust" set to "inlined"
My minor issue was that I found the frame numbering confusing. Markus suggested this:
mstange: yeah you'd have two different types of frame indexes
"normal frame index" and "frame index after inline expansion"
or you could just repeat the same frame index, I think that would be fine too
I'll fix the implementation to match that.
Assignee | ||
Comment 6•2 years ago
|
||
Assignee | ||
Comment 7•2 years ago
|
||
PR 6181 changes the display to the other mockup. It also fixes the ordering which Nika pointed out was wrong. Now it displays inline functions and then the frame function.
Assignee | ||
Comment 8•2 years ago
|
||
Assignee | ||
Comment 9•2 years ago
|
||
This was deployed in bug #1790053. Marking as FIXED.
Description
•