update rust-minidump to 0.14.0
Categories
(Socorro :: Processor, task)
Tracking
(Not tracked)
People
(Reporter: mstange, Assigned: willkg)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
The 0.12.0 release adds compatibility for INLINE / INLINE_ORIGIN records in breakpad .sym files.
It also fixes stackwalking for arm64.
https://github.com/rust-minidump/rust-minidump/blob/main/RELEASES.md
Reporter | ||
Comment 1•2 years ago
|
||
Crash report from a try build for testing: https://crash-stats.mozilla.org/report/index/addcd599-6502-4e51-902e-6f1a60220727
This crash is from this try build, which has symbols which contain inline information.
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 2•2 years ago
|
||
I'm working on building out a schema for the processed crash that includes the output of the stackwalker. That makes it possible for me to reason about changes in rust-minidump output over time while minimizing risk.
Given that, I'm making this dependent on me finishing up that work.
Reporter | ||
Comment 3•2 years ago
|
||
In the meantime, would you be open to updating to 0.12.0? That version does not change anything about the schema, it purely adds compatibility to ensure that the output is unchanged. This would unblock bug 1779631.
rust-minidump 0.14.0 is the version which adds inlines to the JSON.
Assignee | ||
Comment 4•2 years ago
|
||
I can't upgrade at all until I sort out the processed crash schema and some of the bits after that.
Assignee | ||
Comment 5•2 years ago
|
||
Grabbing this to do now.
Assignee | ||
Comment 6•2 years ago
|
||
Assignee | ||
Comment 7•2 years ago
|
||
I needed to add --no-color
to the command line arguments to the stackwalker. Also, the stderr output format changed, so I needed to fix the code that sets mdsw_status_string
to the bit after ERROR
in the error line in stderr to pick up strings like HeaderMismatch
which we use in signature generation to differentiate between the various "no crashing thread identified" issues.
There's some new fields in the stackwalker output. I'll write up a new "handle inline functions" bug which will cover those and what to do with the webapp.
Assignee | ||
Comment 8•2 years ago
|
||
Assignee | ||
Comment 9•2 years ago
|
||
This went to prod just now in bug #1788726. Marking as FIXED.
Description
•