Bug #1779630 updated rust-minidump to 0.14.0 which has support for inline function information. For crash reports that have inline function information in the stackwalker output, we probably want to do something with that information in the signature.

This bug covers figuring out what to do with signatures and making the appropriate changes.

Do we know what needs to be done for this?

I don't know how to factor it in in a way that provides helpful information.

Option 1: include all the inline functions and the frame function:

frame 0 function | frame 1 inline function | frame 1 inline function | frame 1 function | frame 2 function ...

Option 2: include just the first inline function:

frame 0 function | frame 1 inline function | frame 2 function ...

Option 3: include an indication there were inlined things, but use the frame function:

frame 0 function | (inlined things) | frame 1 function | frame 2 function ...

Maybe something else?

I don't know what approach would bucket crashes best. Maybe option 2?

I think we should start by just treating inline frames like regular frames. We don't want the decision about whether a function was inlined to affect the signature.

That makes sense. I'll ... do that now!

willkg merged PR #6193: "bug 1788269: add inline functions to signature" in f62b4f6.

I'll push this to prod next week. If you want to skulk around on https://crash-stats.allizom.org/ (staging server) and look at signatures and you notice anything amiss, let me know.

This got pushed to prod in bug #1790838 just now. Marking as FIXED.