Closed Bug 1791633 Opened 2 years ago Closed 2 years ago

separate TLS socket control from transport security info

Categories

(Core :: Security: PSM, enhancement, P1)

Product:
Core
Component:
Security: PSM
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox109 --- fixed

People

(Reporter: keeler, Assigned: keeler)

References

(Blocks 1 open bug)

Details

(Whiteboard: [psm-assigned])

Attachments

(3 files, 2 obsolete files)

Bug 1791633 - rename nsNSSSocketInfo to NSSSocketControl and move to its own file r?jschanck
(deleted), text/x-phabricator-request
Details
Bug 1791633 - rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r?kershaw
(deleted), text/x-phabricator-request
Details
Bug 1791633 - separate nsITLSSocketControl from nsITransportSecurityInfo r?jschanck
(deleted), text/x-phabricator-request
Details

The TLS socket control implementation (until now called nsISSLSocketControl, soon to be called nsITLSSocketControl) should be separate from the transport security info implementation (nsITransportSecurityInfo).

(This test only needs the bytes of the server certificate, not the entire
nsITransportSecurityInfo of the connection.)

This is an important step in making nsITransportSecurityInfo constant.

Depends on D157994

Comment on attachment 9295905 [details]
WIP: Bug 1791633 - don't serialize securityInfo in browser_aboutCertError_exception.js r?Gijs

Revision D157994 was moved to bug 1793841. Setting attachment 9295905 [details] to obsolete.

Attachment #9295905 - Attachment is obsolete: true

Comment on attachment 9295906 [details]
WIP: Bug 1791633 - deserialize nsITransportSecurityInfo without already having an instance of it r?jschanck

Revision D157995 was moved to bug 1793841. Setting attachment 9295906 [details] to obsolete.

Attachment #9295906 - Attachment is obsolete: true
Attachment #9300255 - Attachment description: WIP: Bug 1791633 - rename nsNSSSocketInfo to NSSSocketControl and move to its own file r?jschanck → Bug 1791633 - rename nsNSSSocketInfo to NSSSocketControl and move to its own file r?jschanck
Attachment #9300256 - Attachment description: WIP: Bug 1791633 - rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r?kershaw → Bug 1791633 - rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r?kershaw
Attachment #9300258 - Attachment description: WIP: Bug 1791633 - separate nsITLSSocketControl from nsITransportSecurityInfo r?jschanck → Bug 1791633 - separate nsITLSSocketControl from nsITransportSecurityInfo r?jschanck
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f57131b9cfe2 rename nsNSSSocketInfo to NSSSocketControl and move to its own file r=jschanck https://hg.mozilla.org/integration/autoland/rev/f5a4bfdaba40 rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/ee9744982673 separate nsITLSSocketControl from nsITransportSecurityInfo r=necko-reviewers,kershaw,jschanck
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab0ea0d68f5c rename nsNSSSocketInfo to NSSSocketControl and move to its own file r=jschanck https://hg.mozilla.org/integration/autoland/rev/0bcba3375ec0 rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/23b864e14db0 separate nsITLSSocketControl from nsITransportSecurityInfo r=necko-reviewers,kershaw,jschanck
Flags: needinfo?(dkeeler)

Backed out 3 changesets (Bug 1791633) for causing bustages on TransportSecurityInfo.cpp.
Backout link
Push with failures <--> Bb
Failure Log

Flags: needinfo?(dkeeler)
Flags: needinfo?(dkeeler)
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/303e70d38862 rename nsNSSSocketInfo to NSSSocketControl and move to its own file r=jschanck https://hg.mozilla.org/integration/autoland/rev/705439f1d269 rename nsISSLSocketControl to nsITLSSocketControl and move it and nsITransportSecurityInfo to PSM r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/b45bd4ea0000 separate nsITLSSocketControl from nsITransportSecurityInfo r=necko-reviewers,kershaw,jschanck
Regressions: 1809755
No longer regressions: 1809755
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: