make TCPSocket work with TLS for Thunderbird
Categories
(Core :: DOM: Networking, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox108 | --- | unaffected |
firefox109 | --- | unaffected |
firefox110 | --- | unaffected |
firefox111 | --- | fixed |
People
(Reporter: mkmelin, Assigned: KaiE, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
TCPSocket.upgradeToSecure doesn't work anymore after bug 1791633 - since operation happens on main thread while it should happen on socket thread.
This means Thunderbird protocols written in js and using TCPSocket don't work with STARTTLS.
Quoting Dana from bug 1801067 comment 35:
Yeah, TCPSocket should probably be fixed. Looking at
https://searchfox.org/mozilla-central/source/dom/webidl/TCPSocket.webidl, many
(all?) of those methods/attributes should probably actually return promises
instead of directly doing whatever operation on the main thread (as opposed to
the socket thread).
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1791633
:keeler, since you are the author of the regressor, bug 1791633, could you take a look? Also, could you set the severity field?
For more information, please visit auto_nag documentation.
This doesn't affect Firefox, since as far as I can tell, TCPSocket is only used for adb remote debugging, which doesn't use TLS. So, this is more of an enhancement for Thunderbird.
Comment 3•2 years ago
|
||
Thank you for the bug.
I don't know if we have any time to fix this ourselves right now, but we're happy to mentor someone in fixing this.
If there is functionality that thunderbird depends on we should have a test for it in mozilla-central so we don't regress this in the future.
Assignee | ||
Comment 4•2 years ago
|
||
Assignee | ||
Comment 5•2 years ago
|
||
Using this patch I am able to send email on comm-beta 110 with a SMTP/STARTTLS server.
(debug build, no assertion is reached)
Assignee | ||
Comment 6•2 years ago
|
||
Ping, could you please apply revisions D165915 + D168111 + D168125 and test if it works for you?
If it doesn't, can you please say which scenarios don't yet work?
Comment 7•2 years ago
|
||
Great, I tested D168125 with smtp, pop3 and imap-js, all work for me, thanks a lot.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 8•2 years ago
|
||
Dana, are you available to please re-review the updated patch?
Sorry for the delay - I was out sick.
Assignee | ||
Comment 10•2 years ago
|
||
Dana, thank you, I very much appreciate your help and hope you're recovering quickly!
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
bugherder |
Reporter | ||
Comment 13•2 years ago
|
||
Thanks Kai, and thanks Dana!
Updated•2 years ago
|
Description
•