Inconsistent colors in some address book dialogs in dark mode
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr102 wontfix, thunderbird106 fixed)
People
(Reporter: aleca, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
rjl
:
approval-comm-beta+
|
Details |
Screenshot from 2022-09-26 20-06-58.png
Some address book dialogs still inherit the Firefox primary color when in dark mode.
We should unify this and make sure the blue we picked for our buttons is consistently used for all other primary/selected/focused elements.
This currently affects all dialog creations of the address book.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/266f3d748f8d
Move our color variables from preferences.css to common.css. r=aleca
|
Reporter | |
Comment 3•2 years ago
|
||
Requesting uplift for beta since bug 1792876 (scheduled for beta uplift) depends on this code to allow a clean merge.
|
|
Reporter | |
Comment 4•2 years ago
|
||
Comment on attachment 9296364 [details]
Bug 1792506 - Move our color variables from preferences.css to common.css. r=aleca
[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Slightly different variation in our accent colour for the address book dialogs when in dark mode
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): very low
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9296364 [details]
Bug 1792506 - Move our color variables from preferences.css to common.css. r=aleca
[Triage Comment]
Approved for beta
|
||
Comment 6•2 years ago
|
||
| bugherder uplift | ||
Thunderbird 106.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/6a09933f66ac
|
||
Updated•2 years ago
|
Description
•