Closed Bug 1793483 Opened 2 years ago Closed 2 years ago

Migrate NS_STYLE_FRAME_* defines

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: ben.freist, Assigned: ben.freist)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1793483 - [refactor] Migrate NS_STYLE_FRAME_* defines r=emilio
(deleted), text/x-phabricator-request
Details

+++ This bug was initially created as a clone of Bug #1793329 +++

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36

I have replaced the NS_STYLE_FRAME_* defines by an enum class called FrameBorderProperty.

Blocks: 1277133
Assignee: nobody → ben.freist
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Severity: -- → N/A
Type: defect → enhancement
Priority: -- → P3
Attached file Bug 1793483 - format code r=emilio (obsolete) (deleted) —

Depends on D158526

Attachment #9297694 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8afa6eaecd2f [refactor] Migrate NS_STYLE_FRAME_* defines r=emilio

Backed out for causing mochitest failures on test_Prototype.html and test_HTMLFrameElement01.html

Backout link

Push with failures - 5 // Push with failures - 12

Failure log - 5 // Failure log - 12

Flags: needinfo?(ben.freist)

I pushed a new version where I've adjusted the test cases, emilio can you please have a look?

Flags: needinfo?(ben.freist) → needinfo?(emilio)

For the record when you upload an already-accepted revision it doesn't go back to the review queue (which is why I missed this). Thanks! Looking now :)

And also, for future reference you can make it go back to the review queue via the "Request Review" item in the phabricator dropdown.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/945d3e5bd717 [refactor] Migrate NS_STYLE_FRAME_* defines r=emilio

https://hg.mozilla.org/mozilla-central/rev/945d3e5bd717

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Regressions: 1797813
No longer regressions: 1797813
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: