Closed Bug 1798836 Opened 2 years ago Closed 2 years ago

The right side of the Profile Manager of [Ja] build nightly is cut off because it is not enough width.

Categories

(Toolkit :: Startup and Profile System, defect)

Firefox 108
Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
108 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox106 --- unaffected
firefox107 --- unaffected
firefox108 --- fixed
firefox109 --- verified

People

(Reporter: alice0775, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(2 files)

Attached image screenshot (deleted) —

Steps to reproduce:

  1. Start Nightly 108.0a1 [Ja] build
    firefox.exe -p

Actual Results:
The right side of the Profile Manager is cut off.

Expected Results:
The right side of the Profile Manager should not be cut off.

:emilio, since you are the author of the regressor, bug 1795224, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

Instead of imposing the min-width as a max-size, make prefwidth act as
it should (as suggesting a preferred width, but with min-content as a
minimum).

This can be reproduced locally by applying a patch like:

diff --git a/toolkit/profile/content/profileSelection.xhtml b/toolkit/profile/content/profileSelection.xhtml
index 3dd1c864f79f1..7e8cbf8ce8c3e 100644
--- a/toolkit/profile/content/profileSelection.xhtml
+++ b/toolkit/profile/content/profileSelection.xhtml
@@ -17,7 +17,7 @@
   data-l10n-id="profile-selection-window"
   orient="vertical"
   prefwidth="min-width"
-  style="min-width: 30em;"
+  style="min-width: 10em;"
   onload="startup();">
 <dialog id="profileWindow"
   buttons="accept,cancel"

Before patch, stuff overflowed. This patch guarantees that everything is
on-screen.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f456713ddff8 Improve sizing of the profile manager (again). r=Gijs,webidl,smaug
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f611ae72ddbf Improve sizing of the profile manager (again). r=Gijs,webidl,smaug
Flags: needinfo?(emilio)

The regressing bug 1795224 was uplifted to Firefox 107. Does this need to be uplifted too?

Flags: needinfo?(emilio)

No, see comment 1

Flags: needinfo?(emilio)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
QA Whiteboard: [qa-108b-p2]

Reproducible on a 2022-11-02 Nightly build( ja-locale) on Windows 10. Verified as fixed on 109.0a1 Nightly(2022-11-15, ja-locale) on Windows 10 and Windows 11.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-108b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: