The right side of the Profile Manager of [Ja] build nightly is cut off because it is not enough width.
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox106 | --- | unaffected |
firefox107 | --- | unaffected |
firefox108 | --- | fixed |
firefox109 | --- | verified |
People
(Reporter: alice0775, Assigned: emilio)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(2 files)
Steps to reproduce:
- Start Nightly 108.0a1 [Ja] build
firefox.exe -p
Actual Results:
The right side of the Profile Manager is cut off.
Expected Results:
The right side of the Profile Manager should not be cut off.
Reporter | ||
Comment 1•2 years ago
|
||
Regression window [ja] build:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ac1330b68d3e7b231a177cfa1ac52e1b2199bb84&tochange=826073b561e026d8fbc6a8354081db59727d9f33
FYI,
The offending patch has been backed out in the mozilla-beta channel only and does not affect 107.0b8.
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?&fromchange=40d2d5014048&tochange=e433b14352f7
Comment 2•2 years ago
|
||
:emilio, since you are the author of the regressor, bug 1795224, could you take a look? Also, could you set the severity field?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Instead of imposing the min-width as a max-size, make prefwidth act as
it should (as suggesting a preferred width, but with min-content as a
minimum).
This can be reproduced locally by applying a patch like:
diff --git a/toolkit/profile/content/profileSelection.xhtml b/toolkit/profile/content/profileSelection.xhtml
index 3dd1c864f79f1..7e8cbf8ce8c3e 100644
--- a/toolkit/profile/content/profileSelection.xhtml
+++ b/toolkit/profile/content/profileSelection.xhtml
@@ -17,7 +17,7 @@
data-l10n-id="profile-selection-window"
orient="vertical"
prefwidth="min-width"
- style="min-width: 30em;"
+ style="min-width: 10em;"
onload="startup();">
<dialog id="profileWindow"
buttons="accept,cancel"
Before patch, stuff overflowed. This patch guarantees that everything is
on-screen.
Updated•2 years ago
|
Comment 5•2 years ago
|
||
Backed out for causing build bustages on Window.webidl.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=395654590&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/09c0763a61da33c2709a4c640d16a3533c677b38
Assignee | ||
Updated•2 years ago
|
Comment 7•2 years ago
|
||
The regressing bug 1795224 was uplifted to Firefox 107. Does this need to be uplifted too?
Comment 9•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Reproducible on a 2022-11-02 Nightly build( ja-locale) on Windows 10. Verified as fixed on 109.0a1 Nightly(2022-11-15, ja-locale) on Windows 10 and Windows 11.
Description
•