As we don't have plans for a followup collection, we need to remove the "New colorways are on the way" message.

https://hg.mozilla.org/mozilla-central/rev/dfe42e743b9c

Comment on attachment 9303818 [details]
Bug 1801037 - Disable "New colorways are on the way" message (patch for beta uplift). r=sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Misleading message as we don't have plans for another colorway collection
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
  • set your system date to something after January 17, 2023
  • launch Firefox
  • open Firefox View
    -> the feature callout tour should skip the colorways step
    -> the page should not have a colorway card, while the page layout should otherwise be unaffected from the card being hidden
  • resize the window a few times and confirm that the page layout still works out
• List of other uplifts needed: bug 1801044
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a simplified patch specifically for beta to reduce risk. (Technically the card is still there, but it's unstyled and hidden.)
• String changes made/needed: n/a
• Is Android affected?: No

I thought we were targeting this for 109, not 108?

(In reply to Sarah Clements [:sclements] from comment #6)

I thought we were targeting this for 109, not 108?

Many users (possibly even most users) may still be on 108 as the collection expires on Jan 17, the 109 release day.

Comment on attachment 9303818 [details]
Bug 1801037 - Disable "New colorways are on the way" message (patch for beta uplift). r=sfoster

Approved for 108.0b4

https://hg.mozilla.org/releases/mozilla-beta/rev/0921777ac545

Verified the STR from Comment 5 with Firefox 108.0b4 and 109.0a1 (2022-11-20) on macOS 13.0.1, Ubuntu 22.04 and Windows 11. The colorway step is skipped, and the colorway card is hidden as expected.

The only visible thing would be that the content in page without the colorway card now looks a bit shifted to the left and not centered, otherwise no other issues were found. Let me know if I can help with anything else.

(In reply to Catalin Sasca, QA [:csasca] from comment #10)

The only visible thing would be that the content in page without the colorway card now looks a bit shifted to the left and not centered, otherwise no other issues were found.

Afaik this is expected. Thanks!