Closed Bug 1801044 Opened 2 years ago Closed 2 years ago

Revert about:addons themes section to its pre-colorway-closet state (i.e. installed colorways will be listed among other installed themes) when the current collection expires

Categories

(Toolkit :: Add-ons Manager, task, P1)

Product:
Toolkit
Component:
Add-ons Manager
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- wontfix
firefox108 --- verified
firefox109 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(3 files)

Bug 1801044 - Revert about:addons themes section to its pre-colorway-closet state (i.e. installed colorways will be listed among other installed themes) when the current collection expires. r=rpl
(deleted), text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details
Beta Screenshot.png
(deleted), image/png
Details
Nightly Screenshot.png
(deleted), image/png
Details
No description provided.
Status: NEW → ASSIGNED
status-firefox107: --- → wontfix
status-firefox108: --- → affected
status-firefox109: --- → affected
status-firefox-esr102: --- → unaffected
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c00efaada7b3 Revert about:addons themes section to its pre-colorway-closet state (i.e. installed colorways will be listed among other installed themes) when the current collection expires. r=rpl

Comment on attachment 9304026 [details]
Bug 1801044 - Revert about:addons themes section to its pre-colorway-closet state (i.e. installed colorways will be listed among other installed themes) when the current collection expires. r=rpl

Beta/Release Uplift Approval Request

  • User impact if declined: Now-undesired differentiation between colorways and themes in about:addons
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: - launch Firefox
    • select a colorway
    • close Firefox
    • set your system date to something after January 17, 2023
    • launch Firefox
    • open about:addons
    • select the default theme
      -> previously selected colorway should appear under "Saved Themes" in alphabetical order
  • List of other uplifts needed: bug 1801037
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): fairly minimal and straightforward patch
  • String changes made/needed: n/a
  • Is Android affected?: No
Attachment #9304026 - Flags: approval-mozilla-beta?
Flags: qe-verify+

https://hg.mozilla.org/mozilla-central/rev/c00efaada7b3

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox109: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

Comment on attachment 9304026 [details]
Bug 1801044 - Revert about:addons themes section to its pre-colorway-closet state (i.e. installed colorways will be listed among other installed themes) when the current collection expires. r=rpl

Approved for 108.0b4

Attachment #9304026 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified as Fixed on the latest Nightly (109.0a1/20221120214001) and Beta (108.0b4/20221120185746). Tested on Windows 10 x64 and Ubuntu 16.04 LTS.

Following the provided STR from Comment 3, previously enabled colorways are displayed under “Saved Themes”, in alphabetical order and can be properly enabled/applied.

For further details, see the attached screenshots from both Beta and Nightly.

Status: RESOLVED → VERIFIED
status-firefox108: fixed → verified
status-firefox109: fixed → verified
Flags: qe-verify+
Attached image Beta Screenshot.png (deleted) —
Attached image Nightly Screenshot.png (deleted) —
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: