Closed Bug 1804295 Opened 2 years ago Closed 2 years ago

Remove the current use of favorPerformanceHint and change the mechanism to have a short burst of Gecko tasks over native tasks

Categories

(Core :: Widget, enhancement, P3)

Product:
Core
Component:
Widget
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Regressed 1 open bug)

Details

Attachments

(4 files)

Bug 1804295 - Remove the current use of favorPerformanceHint, r=emilio
(deleted), text/x-phabricator-request
Details
Bug 1804295, Add GeckoTasksBurst, r=emilio
(deleted), text/x-phabricator-request
Details
Bug 1804295, RequestGeckoTaskBurst for process switch, r=emilio
(deleted), text/x-phabricator-request
Details
Bug 1804295, a tweak to refreshdriver scheduling during page load, r=emilio
(deleted), text/x-phabricator-request
Details

The current use of favorPerformanceHint is very error prone. We've had cases where we stay in the wrong mode forever.
I thought we should remove perf mode (bug 930793), but I think I've found a case where it is actually useful (during process switch of content processes).
But anyhow, the current use of the API is just bizarre.

Severity: -- → N/A
Priority: -- → P3

Depends on D163964

Attachment #9309126 - Attachment description: WIP: Bug 1804295, GeckoTasksBurst in process switch → WIP: Bug 1804295, GeckoTasksBurst for process switch and child process document load
Attachment #9309126 - Attachment description: WIP: Bug 1804295, GeckoTasksBurst for process switch and child process document load → WIP: Bug 1804295, GeckoTasksBurst for process switch
Attachment #9309126 - Attachment description: WIP: Bug 1804295, GeckoTasksBurst for process switch → WIP: Bug 1804295, GeckoTaskBurst for process switch
Attachment #9309551 - Attachment description: WIP: Bug 1804295, Don't deprioritize refreshdriver so much during page load → WIP: Bug 1804295, deprioritize refreshdriver even more during page load
Attachment #9309551 - Attachment description: WIP: Bug 1804295, deprioritize refreshdriver even more during page load → WIP: Bug 1804295, remove page load specific refreshdriver scheduling
Attachment #9309551 - Attachment description: WIP: Bug 1804295, remove page load specific refreshdriver scheduling → WIP: Bug 1804295, deprioritize refreshdriver even more during page load
Attachment #9309551 - Attachment description: WIP: Bug 1804295, deprioritize refreshdriver even more during page load → WIP: Bug 1804295, a tweak to refreshdriver scheduling during page load
Summary: Consider to remove the current use of favorPerformanceHint → Remove the current use of favorPerformanceHint and change the mechanism to have a short burst of Gecko tasks over native tasks
Attachment #9306914 - Attachment description: WIP: Bug 1804295 - Remove the current use of favorPerformanceHint → Bug 1804295 - Remove the current use of favorPerformanceHint
Attachment #9309125 - Attachment description: WIP: Bug 1804295, Add GeckoTasksBurst → Bug 1804295, Add GeckoTasksBurst
Attachment #9309126 - Attachment description: WIP: Bug 1804295, GeckoTaskBurst for process switch → Bug 1804295, GeckoTaskBurst for process switch
Attachment #9309551 - Attachment description: WIP: Bug 1804295, a tweak to refreshdriver scheduling during page load → Bug 1804295, a tweak to refreshdriver scheduling during page load
Attachment #9306914 - Attachment description: Bug 1804295 - Remove the current use of favorPerformanceHint → Bug 1804295 - Remove the current use of favorPerformanceHint, r=emilio
Attachment #9309125 - Attachment description: Bug 1804295, Add GeckoTasksBurst → Bug 1804295, Add GeckoTasksBurst, r=emilio
Attachment #9309126 - Attachment description: Bug 1804295, GeckoTaskBurst for process switch → Bug 1804295, RequestGeckoTaskBurst for process switch, r=emilio
Attachment #9309551 - Attachment description: Bug 1804295, a tweak to refreshdriver scheduling during page load → Bug 1804295, a tweak to refreshdriver scheduling during page load, r=emilio
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d813eca250a1 Remove the current use of favorPerformanceHint, r=emilio https://hg.mozilla.org/integration/autoland/rev/81486c049a63 Add GeckoTasksBurst, r=emilio https://hg.mozilla.org/integration/autoland/rev/983c2f1ce187 RequestGeckoTaskBurst for process switch, r=emilio https://hg.mozilla.org/integration/autoland/rev/7966f6606190 a tweak to refreshdriver scheduling during page load, r=emilio
Regressions: 1807838
Regressions: 1795538
No longer regressions: 1795538
Regressions: 1816748
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: