[Windows] Profile manager window size glitch on startup
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox108 | --- | unaffected |
firefox109 | --- | unaffected |
firefox110 | --- | verified |
People
(Reporter: ailea, Assigned: smaug)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files, 3 obsolete files)
Found in
- 110.0a1 (2022-12-28)
Affected versions
- 110.0a1 (2022-12-28)
Tested platforms
- Affected platforms: Windows 10
- Unaffected platforms: macOS, Ubuntu
Steps to reproduce
- Launch the Fx profile manager.
Expected result
- The profile manager is opened accordingly without any glitches.
Actual result
- There is a glitch with the size of the profile manager window on startup.
Regression range
This is a regression from 2022-12-27. It worked ok on 110.0a1 (2022-12-27, build id: 20221227093156) and start broken on 110.0a1 (2022-12-27, build id: 20221227211321). Will try to find a more detailed regression range asap.
Comment 1•2 years ago
|
||
Regression window:
ttps://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4b2e3689cea010e9473792bd8f5a8606c862e09d&tochange=7966f6606190515258c3f19ad4d05ed4d317f164
Comment 2•2 years ago
|
||
:smaug, since you are the author of the regressor, bug 1804295, could you take a look?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 3•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
I think this is a combination of bug 1795224 and bug 1804295. The first one added sizeToContent call, which triggers second SetSize call, where the height is a tiny bit larger.
Still investigating
Assignee | ||
Comment 5•2 years ago
|
||
Oh, actually this is even older than bug 1795224.
Updated•2 years ago
|
Assignee | ||
Comment 6•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 7•2 years ago
|
||
Updated•2 years ago
|
Comment 8•2 years ago
|
||
In this case we can do easier things than going through the shell and
assuming all sizes go through the window.
Updated•2 years ago
|
Comment 9•2 years ago
|
||
(didn't mean to steal, can move comment 8 to another bug if / as needed)
Updated•2 years ago
|
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Comment 11•2 years ago
|
||
Backed out changeset 7f9088d3354d (Bug 1807838) for causing bc failures on browser_modal_resize.js.
Backout link
Push with failures <--> bc4
Failure Log
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
bugherder |
Reporter | ||
Comment 14•2 years ago
|
||
Verified - Fixed in latest Nightly 110.0a1 (build id: 20230111043919) using Windows 10. The profile manager window is now opened accordingly.
Comment 15•2 years ago
|
||
Comment on attachment 9311408 [details]
Bug 1807838 - Simplify AppWindow::SizeShellTo when sizing to the window shell. r=smaug
Revision D166367 was moved to bug 1810614. Setting attachment 9311408 [details] to obsolete.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Description
•