Closed Bug 1807838 Opened 2 years ago Closed 2 years ago

[Windows] Profile manager window size glitch on startup

Categories

(Toolkit :: Startup and Profile System, defect)

Firefox 110
Desktop
Windows
defect

Tracking

()

VERIFIED FIXED
110 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox108 --- unaffected
firefox109 --- unaffected
firefox110 --- verified

People

(Reporter: ailea, Assigned: smaug)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 3 obsolete files)

Attached video 2022-12-28_15h35_39.mp4 (deleted) —

Found in

  • 110.0a1 (2022-12-28)

Affected versions

  • 110.0a1 (2022-12-28)

Tested platforms

  • Affected platforms: Windows 10
  • Unaffected platforms: macOS, Ubuntu

Steps to reproduce

  1. Launch the Fx profile manager.

Expected result

  • The profile manager is opened accordingly without any glitches.

Actual result

  • There is a glitch with the size of the profile manager window on startup.

Regression range
This is a regression from 2022-12-27. It worked ok on 110.0a1 (2022-12-27, build id: 20221227093156) and start broken on 110.0a1 (2022-12-27, build id: 20221227211321). Will try to find a more detailed regression range asap.

Regression window:
ttps://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4b2e3689cea010e9473792bd8f5a8606c862e09d&tochange=7966f6606190515258c3f19ad4d05ed4d317f164

Regressed by: 1804295

:smaug, since you are the author of the regressor, bug 1804295, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(smaug)
Attachment #9310055 - Attachment description: WIP: Bug 1807838, favor Gecko tasks for a short while during page load in the parent process → WIP: Bug 1807838, favor Gecko tasks for a short while after page load in the parent process

I think this is a combination of bug 1795224 and bug 1804295. The first one added sizeToContent call, which triggers second SetSize call, where the height is a tiny bit larger.
Still investigating

Regressed by: 1795224

Oh, actually this is even older than bug 1795224.

No longer regressed by: 1795224
Attachment #9310055 - Attachment is obsolete: true
Attachment #9310415 - Attachment is obsolete: true
Flags: needinfo?(smaug)
Attachment #9310754 - Attachment description: WIP: Bug 1807838, keep dialog window hidden until its final size can be set → WIP: Bug 1807838, try to translate elements before load event fires

In this case we can do easier things than going through the shell and
assuming all sizes go through the window.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

(didn't mean to steal, can move comment 8 to another bug if / as needed)

Assignee: emilio → nobody
Status: ASSIGNED → NEW
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Attachment #9310754 - Attachment description: WIP: Bug 1807838, try to translate elements before load event fires → Bug 1807838, try to translate elements before load event fires, r=emilio
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f9088d3354d Simplify AppWindow::SizeShellTo when sizing to the window shell. r=smaug

Backed out changeset 7f9088d3354d (Bug 1807838) for causing bc failures on browser_modal_resize.js.
Backout link
Push with failures <--> bc4
Failure Log

Flags: needinfo?(emilio)
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01f0f5a5c206 try to translate elements before load event fires, r=emilio
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

Verified - Fixed in latest Nightly 110.0a1 (build id: 20230111043919) using Windows 10. The profile manager window is now opened accordingly.

Status: RESOLVED → VERIFIED

Comment on attachment 9311408 [details]
Bug 1807838 - Simplify AppWindow::SizeShellTo when sizing to the window shell. r=smaug

Revision D166367 was moved to bug 1810614. Setting attachment 9311408 [details] to obsolete.

Attachment #9311408 - Attachment is obsolete: true
Flags: needinfo?(emilio)
Assignee: emilio → smaug
Regressions: 1811489
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: