Closed
Bug 1808894
Opened 2 years ago
Closed 2 years ago
Update code to check for stale elements based on WebDriver classic PR 1707
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(firefox111 fixed)
RESOLVED
FIXED
111 Branch
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 2 open bugs, )
Details
(Whiteboard: [webdriver:m6][webdriver:relnote])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
James is currently rewriting the WebDriver classic spec in terms of stale element checks. We have to update our code regarding to these changes.
Especially element.resolveElement()
needs to differentiate between WebElement
and ShadowRoot
.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
My proposal would be to include this bug into M6 specifically to the Shadow DOM related work.
Whiteboard: [webdriver:triage]
Assignee | ||
Updated•2 years ago
|
Severity: -- → S3
Points: --- → 2
Priority: -- → P1
Whiteboard: [webdriver:triage] → [webdriver:m6]
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Comment 4•2 years ago
|
||
The real underlying fix for bug 1764594 has been moved back to bug 1764594 for better tracking.
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75eaaf96d039 [marionette] Complete (De-)serialization support for WebElement and ShadowRoot. r=webdriver-reviewers,jdescottes
Comment 6•2 years ago
|
||
It seems this landed with leftover files from a puppeteer install (under remote/test/puppeteer/packages/puppeteer-core/). We might want to backout or followup to cleanup the files?
Flags: needinfo?(hskupin)
Comment 7•2 years ago
|
||
Backed out for landing with leftover files from a puppeteer install (under remote/test/puppeteer/packages/puppeteer-core/).
Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a17a55187bdc [marionette] Complete (De-)serialization support for WebElement and ShadowRoot. r=webdriver-reviewers,jdescottes
Comment 9•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Updated•2 years ago
|
Product: Testing → Remote Protocol
Assignee | ||
Updated•2 years ago
|
Whiteboard: [webdriver:m6] → [webdriver:m6][webdriver:relnote]
You need to log in
before you can comment on or make changes to this bug.
Description
•