Closed Bug 1811545 Opened 2 years ago Closed 2 years ago

[wdspec] Refactor tests for "stale element reference", "detached shadow root", and "no such shadow root" checks

Categories

(Testing :: geckodriver, task, P1)

Product:
Testing
Component:
geckodriver
Version:
Default
Type:
task
Points:
3

Tracking

(firefox111 fixed)

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [webdriver:m6], [wptsync upstream])

Attachments

(5 files)

Bug 1811545 - [wdspec] Enhance stale_element fixture for shadow root nodes.
(deleted), text/x-phabricator-request
Details
Bug 1811545 - [wdspec] Update test_no_such_element_from_other_frame tests for get_test_page fixture.
(deleted), text/x-phabricator-request
Details
Bug 1811545 - [wdspec] Improve Find Element(s) tests for unknown selector.
(deleted), text/x-phabricator-request
Details
Bug 1811545 - [wdspec] Update element and shadow root specific tests for existence and stale / detached state.
(deleted), text/x-phabricator-request
Details
Bug 1811545 - [wdspec] Remove usage of custom shadow root pages in favor of test_page fixture.
(deleted), text/x-phabricator-request
Details

Over on bug 1808894 I'm updating the internal behavior of Marionette to correctly handle all the mentioned states for all commands. While doing that I noticed quite a few mistakes in the tests and especially areas that could be massively simplified.

Points: --- → 3
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/55cec0043044 [wdspec] Enhance stale_element fixture for shadow root nodes. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/3e0178b3e0dc [wdspec] Update test_no_such_element_from_other_frame tests for get_test_page fixture. r=webdriver-reviewers,Sasha,jdescottes https://hg.mozilla.org/integration/autoland/rev/82dee6290057 [wdspec] Improve Find Element(s) tests for unknown selector. r=webdriver-reviewers,Sasha,jdescottes https://hg.mozilla.org/integration/autoland/rev/41daafb5d75a [wdspec] Update element and shadow root specific tests for existence and stale / detached state. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/7f0a872abb09 [wdspec] Remove usage of custom shadow root pages in favor of test_page fixture. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38208 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m6] → [webdriver:m6], [wptsync upstream]

Backed out for landing with leftover files from a puppeteer install (under remote/test/puppeteer/packages/puppeteer-core/).

Upstream PR was closed without merging
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1d531994672 [wdspec] Enhance stale_element fixture for shadow root nodes. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/46c66c218e37 [wdspec] Update test_no_such_element_from_other_frame tests for get_test_page fixture. r=webdriver-reviewers,Sasha,jdescottes https://hg.mozilla.org/integration/autoland/rev/10f659a58511 [wdspec] Improve Find Element(s) tests for unknown selector. r=webdriver-reviewers,Sasha,jdescottes https://hg.mozilla.org/integration/autoland/rev/d84d48ee0d61 [wdspec] Update element and shadow root specific tests for existence and stale / detached state. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/7724c46f2973 [wdspec] Remove usage of custom shadow root pages in favor of test_page fixture. r=webdriver-reviewers,jdescottes
Upstream PR was closed without merging
Upstream PR was closed without merging
Upstream PR merged by jgraham
No longer regressions: 1814835
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: