Closed Bug 1809057 Opened 2 years ago Closed 2 years ago

Make sure all sizemode changes do go through FrameState::SetSizeModeInternal

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox109 --- wontfix
firefox110 --- wontfix
firefox111 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1809057 - Make sure all sizemode changes do go through FrameState::SetSizeModeInternal. r=rkraesig,cmartin
(deleted), text/x-phabricator-request
Details
No description provided.

I wrote this while debugging / fixing bug 1806438, but this is kind of
orthogonal. Instead of doing it using a member variable like I did
initially, let's just be explicit and pass whether we need ShowWindow()
etc done as part of the arguments to EnsureSizeMode and co.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1de22258a95c Make sure all sizemode changes do go through FrameState::SetSizeModeInternal. r=rkraesig
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/be4ba160f2a9 Do the ShowWindowAndFocus::No on the right message.
Duplicate of this bug: 1809757

The following field has been copied from a duplicate bug:

Field Value Source
Regressed by bug 1800416 bug 1809757

For more information, please visit auto_nag documentation.

Keywords: regression
Regressed by: 1800416

This bug has the keyword regression, so its type should be defect.

Type: task → defect
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4debd5a21cd9 Make sure all sizemode changes do go through FrameState::SetSizeModeInternal. r=rkraesig
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aab34aaa9876 Make sure all sizemode changes do go through FrameState::SetSizeModeInternal. r=rkraesig
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/874c16494039 Backed out changeset 4debd5a21cd9 for causing bc windows failures on browser_test_data_text_csv.js. CLOSED TREE

Nevermind comment 10, it was due to a wrong copy of the revision number for another backout. The patch was relanded in comment 9.

Phew, thanks Cosmin!

Flags: needinfo?(emilio)

Set release status flags based on info from the regressing bug 1800416

status-firefox109: --- → affected
status-firefox110: --- → affected
status-firefox111: --- → affected
status-firefox-esr102: --- → unaffected

https://hg.mozilla.org/mozilla-central/rev/aab34aaa9876

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
No longer duplicate of this bug: 1809757

Is that something that would benefit our 110 release with an uplift or can it ride the 111 train? Thanks

Flags: needinfo?(emilio)

This is historically rather tricky code, so I'd rather let it ride the trains.

Flags: needinfo?(emilio)
Regressions: 1811489
No longer regressions: 1811489
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: