Closed Bug 1809757 Opened 2 years ago Closed 2 years ago

The taskbar is not hidden after restore sizemode from minimized fullscreen.

Categories

(Core :: Widget: Win32, defect, P3)

Product:
Core
Component:
Widget: Win32
Version:
Firefox 108
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox108 --- wontfix
firefox109 --- wontfix
firefox110 --- wontfix
firefox111 --- verified

People

(Reporter: alice0775, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

Bug 1809757 - Consistently fire activation for window restore. r=rkraesig,cmartin
(deleted), text/x-phabricator-request
Details

Steps to reproduce:

  1. Turn off 'Automatically hide taskbar' on Windows 10 taskbar settings.

  2. Start Nightly110.0a1

  3. Press F11 key, so that browser is fullscreen.

  4. Move mouse to top-side of screen, so that Window control buttons appears.

  5. Click minimize button, so that browser is minimized.

  6. Click Nightly taskbar button to restore browser window.
    --- observe the taskbar is still visible --- BUG

  7. Click Nightly taskbar button instead of the Window control buttons to minimize window.

  8. Click Nightly taskbar button to restore browser window.
    --- observe the taskbar will be hidden --- GOOD

Actual results:
The taskbar is not hidden after restore sizemode from minimized fullscreen.

Bug 1806438 did not fix this

Edge works as expected.

Expected results:
The taskbar sould be hidden after restore sizemode from minimized fullscreen.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=73c2e39ed3070b7e61f33fca7f7c2376949cfa6c&tochange=7ae4a0fd85bf7576d53c390599238b557fa93c10

Severity: -- → S3
Flags: needinfo?(emilio)
Priority: -- → P3

Yeah, bug 1809057 is the actual fix for this in some systems, see commit message there.

Status: NEW → RESOLVED
Closed: 2 years ago
Duplicate of bug: 1809057
Flags: needinfo?(emilio)
Resolution: --- → DUPLICATE

Bug 1809057 did not fix this.
I can still reproduce this issue on Nightly111.0a1 (20230117161302).

Status: RESOLVED → REOPENED
status-firefox110: affected → fix-optional
status-firefox111: --- → affected
No longer duplicate of bug: 1809057
Resolution: DUPLICATE → ---
Status: REOPENED → NEW

See comment #2

Flags: needinfo?(emilio)

This makes the event order of restoring a minimized, maximized, and
normal window in sync, fixing this bug.

Round N of hopefully-not-infinite of trying to make this code more
sensible.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0577733e69fa Consistently fire activation for window restore. r=rkraesig

https://hg.mozilla.org/mozilla-central/rev/0577733e69fa

Status: ASSIGNED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Flags: qe-verify+

Reproduced the issue with Firefox 110.0a1 (2023-01-11) on Windows 10x64 by following the STR from comment 0. Restoring Firefox from the taskbar after minimizing it while fullscreen will still display the taskbar.
The issue is verified fixed with Firefox 111.0b8 on Windows 10x64. Restoring Firefox from the taskbar will no longer display the taskbar.

Status: RESOLVED → VERIFIED
status-firefox111: fixed → verified
Flags: qe-verify+
Regressions: 1823284
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: