Closed Bug 1809430 Opened 2 years ago Closed 2 years ago

Fix nsWindow::ClientToWindowSize with custom non-client margins.

Categories

(Core :: Widget: Win32, defect, P3)

Product:
Core
Component:
Widget: Win32
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(4 files)

Bug 1809430 - Fix nsWindow::ClientToWindowSize with custom non-client margins. r=cmartin,smaug
(deleted), text/x-phabricator-request
Details
Bug 1809430 - Fix nsCocoaWindow::ClientToWindowSize with custom non-client margins. r=mstange,spohl
(deleted), text/x-phabricator-request
Details
Bug 1809430 - Clean up ClientToWindowRect. r=smaug,cmartin,mstange
(deleted), text/x-phabricator-request
Details
Bug 1809430 - Make some tests account for smaller default window size on macOS. r=tnikkel,botond
(deleted), text/x-phabricator-request
Details
No description provided.

This fixes the failures that got the patch from bug 1807838 backed out
on Windows.

MacOS needs a similar fix.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Duplicate of this bug: 1445738

Similar fix as for windows above, see the comment.

Make it return a margin from client area to window area, and add an
explicit function to get the size difference.

No behavior change.

Depends on D166428

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/948fc6987251 Fix nsWindow::ClientToWindowSize with custom non-client margins. r=cmartin https://hg.mozilla.org/integration/autoland/rev/5608823689cf Fix nsCocoaWindow::ClientToWindowSize with custom non-client margins. r=mstange
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f2913c81558 Clean up ClientToWindowRect. r=cmartin,mstange

Before these patches we were adding the titlebar height even though we
were not rendering it.

This made an apz mochitest with hardcoded heights to fail on macOS.

It also perturbed browser_html_scroll_restoration.js in a way such as
the scroll position after a resize is rounded in a different direction,
but that is harmless.

I fixed the cocoa patch for test_maximized_persist.xhtml, and landed a fix for the other two tests.

Flags: needinfo?(emilio)

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(spohl.mozilla.bugs)
Severity: -- → S3
Flags: needinfo?(spohl.mozilla.bugs)
Priority: -- → P3
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/498dbccf6d60 Fix nsWindow::ClientToWindowSize with custom non-client margins. r=cmartin https://hg.mozilla.org/integration/autoland/rev/b3f5d33219c9 Fix nsCocoaWindow::ClientToWindowSize with custom non-client margins. r=mstange https://hg.mozilla.org/integration/autoland/rev/f894f442718a Clean up ClientToWindowRect. r=cmartin,mstange https://hg.mozilla.org/integration/autoland/rev/c996a95c0bf7 Make some tests account for smaller default window size on macOS. r=botond https://hg.mozilla.org/integration/autoland/rev/881f517fefec apply code formatting via Lando
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/5e5bbdf74c1f Minor follow-up test fixes and tweaks.
Regressions: 1813303
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: