Closed Bug 1815320 Opened 2 years ago Closed 2 years ago

Update Safari permission step in migrator to be a folder picker for the Safari folder under ~/Library

Categories

(Firefox :: Migration, task, P3)

Desktop
macOS
task

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox113 --- verified

People

(Reporter: mconley, Assigned: alew7)

References

Details

Attachments

(1 file)

Bugs such as bug 326701 and bug 1236916 require read access to the ~/Library/Safari folder. Up until now, we've gotten the permission to read Bookmarks by asking the user to jump through the hoop of selecting the Bookmarks.plist file via a native file picker (which then gives Firefox read access to the file - and other .plist files, interestingly).

That's not going to help with the favicons / history databases. So this patch is for updating the copy for the Safari permission step to have the user select the Safari folder under ~/Library, and to update the SafariProfileMigrator to show a folder picker rather than a file picker, and have it default to showing ~/Library.

We'll want to update the messaging in both the old migration wizard dialog, and the new one - but since the new one hasn't been finished yet, that can be done in a separate bug when it starts being developed.

Severity: -- → S3
Priority: -- → P1
Blocks: 326701
No longer blocks: 1801313
Assignee: nobody → alew7
Attachment #9320674 - Attachment description: Bug 1815320 - Update Safari permission step in migrator to be a folder picker for the Safari folder under ~/Library. r?mconley → Bug 1815320 - Update Safari permission step in migrator to be a folder picker for the Safari folder under ~/Library. r?mconley!
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b3f7d4d4578 Update Safari permission step in migrator to be a folder picker for the Safari folder under ~/Library. r=mconley,flod
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

Verified as part of QA-1784 that the Safari folder needs to be selected on macOS12 for the migration to be successful. Also verified that user bookmarks and favicons are correctly imported into Firefox Nightly 113.0a1.

We will leave this open until verification is performed on Firefox 113 beta as well.

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #5)

Verified as part of QA-1784 that the Safari folder needs to be selected on macOS12 for the migration to be successful. Also verified that user bookmarks and favicons are correctly imported into Firefox Nightly 113.0a1.

We will leave this open until verification is performed on Firefox 113 beta as well.

Verified with Firefox Beta that the Safari folder needs to be selected on macOS 12 ARM and macOS 13 ARM for the migration to be successful. The bookmarks and their favicons are successfully imported.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: