Closed Bug 326701 Opened 19 years ago Closed 2 years ago

Favicons should be imported from Safari

Categories

(Firefox :: Migration, enhancement)

Product:
Firefox
Component:
Migration
Platform:
All
macOS
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
relnote-firefox --- 113+
firefox113 --- verified

People

(Reporter: pamg.bugs, Assigned: alew7)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 326701 - Favicons should be imported from Safari r?mconley!
(deleted), text/x-phabricator-request
Details
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20060131 Firefox/1.5 Bookmarks and history pages imported from Safari do not have favicons. Icons are an enormous convenience, much easier to scan than page titles. Reproducible: Always Steps to Reproduce: 1. Launch Safari 2. Create some data to be imported: visit a few websites with favicons and create a few bookmarks of sites with favicons 3. Quit Safari 4. Launch Firefox 5. Import profile from Safari 6. Show Places 7. Select History from Places sidebar 8. Open "From Safari" folder in Bookmarks Menu in Places sidebar 9. Select a bookmark folder within "From Places"; e.g., "News" Actual Results: Default, plain document icons appear next to imported history and bookmark items. Expected Results: Sites' favicons should appear next to imported items. This is the 20060131 Places build, posted as the 20060128 nightly.
Assignee: nobody → annie.sullivan
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Target Milestone: --- → Firefox 2 beta1
They're not imported in 1.5 either.
Component: Places → Migration
QA Contact: places → migration
This bug is still present in the RC1 candidate build, Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008051202 Firefox/3.0.
Version: unspecified → Trunk
Assignee: annie.sullivan → nobody
Target Milestone: Firefox 2 beta1 → ---
This is doable (and done by Chrome), but not done by both IE and Chrome migrators.
Severity: normal → enhancement
Priority: P3 → --
Hardware: PowerPC → All
Blocks: 710259
Blocks: calstate
Summary: Import from Safari does not import favicons → Favicons should be imported from Safari

Hi Alvin. I've assigned you to this ticket. It would help if you could help us understand how Safari stores favicons for bookmarks/favourites. Please write down any notes in this document: https://docs.google.com/document/d/1-EXftMTulIkILXieytgW-iB4iJrrkMxaVFsqNU6MGl8/edit#. Reach out to us on Matrix if you have any questions!

Assignee: nobody → alew7
Status: NEW → ASSIGNED
Severity: normal → S3
Attachment #9302042 - Attachment description: WIP: Bug 326701 - Favicons should be imported from Safari r?mconley → Bug 326701 - Favicons should be imported from Safari r?mconley
Attachment #9302042 - Attachment description: Bug 326701 - Favicons should be imported from Safari r?mconley → WIP: Bug 326701 - Favicons should be imported from Safari r?mconley
Attachment #9302042 - Attachment description: WIP: Bug 326701 - Favicons should be imported from Safari r?mconley → Bug 326701 - Favicons should be imported from Safari r?mconley
Attachment #9302042 - Attachment description: Bug 326701 - Favicons should be imported from Safari r?mconley → WIP: Bug 326701 - Favicons should be imported from Safari r?mconley
Attachment #9302042 - Attachment description: WIP: Bug 326701 - Favicons should be imported from Safari r?mconley → Bug 326701 - Favicons should be imported from Safari r?mconley
Attachment #9302042 - Attachment description: Bug 326701 - Favicons should be imported from Safari r?mconley → Bug 326701 - Favicons should be imported from Safari r?mconley!
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c30b41903bf Favicons should be imported from Safari r=mconley

https://hg.mozilla.org/mozilla-central/rev/7c30b41903bf

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

Release Note Request (optional, but appreciated)
[Why is this notable]:

Users that import from Safari will find that most of their bookmark favicons should appear, rather than being the default globe favicon.

This is similar to bug 711995, which adds favicon import support to Chrome-based browsers.

[Affects Firefox for Android]:

No.

[Suggested wording]:

Importing bookmarks from Safari or a Chrome-based browser? The favicons for those bookmarks will now also be imported by default to make them easier to identify.

[Links (documentation, blog post, etc)]:

None.

relnote-firefox: --- → ?

Added to the 113 Nightly relnotes, thanks!

relnote-firefox: ? → 113+

Verified as part of QA-1784 that user bookmarks and favicons are successfully imported into Firefox Nightly 113.0a1 on macOS 12 while the Safari browser is closed or opened. We encountered only one S3 issue (bug 1822828) which is not a blocker for this implementation.

We will leave this open until verification is performed on Firefox 113 beta as well.

Verified as part of QA-1784 that user bookmarks and favicons are successfully imported into Firefox Beta on macOS 12 arm while the Safari browser is closed or opened. Only one S3 issue (bug 1822828) was encountered which is not a blocker for this implementation.
More details can be found in Testrail Report.

Status: RESOLVED → VERIFIED
status-firefox113: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: