[DNR] Add DYNAMIC_RULESET_ID and SESSION_RULESET_ID constants
Categories
(WebExtensions :: Request Handling, task)
Tracking
(firefox111 fixed)
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: robwu, Assigned: robwu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
While finalizing the review of the DNR API documentation for MDN (e.g. BCD), I noticed that while we do recognize the "_session"
and "_dynamic"
values as rulesetIds, we don't expose them as constants to the DNR namespace.
As there are no APIs that take these ruleset IDs, I don't see any issue with never defining them (e.g. Safari does not either), but since it's trivial to add them and they're part of the namespace defined in Chromium, let's do so.
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Comment 3•2 years ago
|
||
bugherder |
Assignee | ||
Comment 5•2 years ago
|
||
We've already ensured that this entry is part of the BCD, at https://github.com/mdn/browser-compat-data/pull/18403
- https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/SESSION_RULESET_ID
- https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/DYNAMIC_RULESET_ID
It currently lists Firefox as "unsupported", because we haven't added Firefox to any BCD entry yet. That is because the feature is disabled by default, behind a preference. When we ship (bug 1782685), we'll update the BCD entries.
Description
•