potential deadlock in TCPSocket::ActivateTLS
Categories
(Core :: Networking, defect, P3)
Tracking
()
People
(Reporter: mkmelin, Unassigned)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1816633 +++
Following up on Emilio's 1816633 comment 2.
Bug 1809755 introduced a very similar issue (sync dispatch from main to socket thread). Is there any reason that really needs to be sync?
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Comment 1•2 years ago
|
||
|
|
Reporter | |
Comment 2•2 years ago
|
||
Maybe something like this would be better? It works, but I'm not familiar enough to say if it's the right thing t do.
|
||
Comment 3•2 years ago
|
||
I think this makes sense. Kai, could you take a look?
I'm not sure why that runnable is sync. If calling upgradeToSecure needs to block, then maybe we can make it a promise, or pass it a callback instead?
|
||
Comment 4•2 years ago
|
||
Valentin, please see my comment in phab, is there a risk that it creates a race?
|
|
||
Comment 5•2 years ago
|
||
(In reply to Kai Engert (:KaiE:) from comment #4)
Valentin, please see my comment in phab, is there a risk that it creates a race?
Yes, Dana already answered that. It would be better to make that a promise.
Description
•