Closed Bug 1821333 Opened 2 years ago Closed 2 years ago

A bookmark with long name clips Bookmarks Menu button popup

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- unaffected
firefox111 --- unaffected
firefox112 --- disabled
firefox113 --- verified

People

(Reporter: Fanolian+BMO, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression, reproducible)

Attachments

(4 files)

Bookmarks Menu button
(deleted), image/png
Details
Long bookmark name in a folder.png
(deleted), image/png
Details
A better screenshot illustrating the bug.png
(deleted), image/png
Details
Bug 1821333 - Fix sizing of drop-indicator-container. r=Gijs,dao
(deleted), text/x-phabricator-request
Details
Attached image Bookmarks Menu button (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0
Build ID: 20230309093044

Steps to reproduce

  1. In a new profile, add Bookmark Menu button to toolbar.
  2. Create a bookmark which:
    2a. has a really long bookmark name
    2b. is put in location "Bookmarks Menu"
  3. Click the Bookmarks Menu button.

Actual result

The right side of the popup is clipped. Please see the attached screenshot.

Expected result

Keyboard shortcuts, right chevrons from folders should be displayed correctly.

Notes

The bug is not exhibited if the bookmark with a long name is placed inside a folder.

Regression

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef92fd4234fd4d7f7b920c97963a0601a49ba841&tochange=eb60b87c68766aa64029cd023bd71d14320ac9c1
This is regressed by bug 1820534.

Flags: needinfo?(emilio)
Attached image Long bookmark name in a folder.png (deleted) —

The bug is not exhibited if the bookmark with a long name is placed inside a folder.

Sorry. This is a better screenshot showing the bug.

Has STR: --- → yes
Keywords: nightly-community, regression, reproducible
Regressed by: 1820534

drop-indicator-container is the direct child of places popups, so needs
-moz-box-flex for the time being until bug 1809084 lands (hopefully
soon).

Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(emilio)
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3727590c972c Fix sizing of drop-indicator-container. r=Gijs

Set release status flags based on info from the regressing bug 1820534

status-firefox110: --- → unaffected
status-firefox111: --- → unaffected
status-firefox112: --- → affected
status-firefox-esr102: --- → unaffected

https://hg.mozilla.org/mozilla-central/rev/3727590c972c

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch

This was backed out of beta v112 via bug 1820534

status-firefox112: fixed → disabled
status-firefox113: --- → fixed
Target Milestone: 112 Branch → 113 Branch
Target Milestone: 113 Branch → 112 Branch
Flags: qe-verify+

Reproduced the initial issue described in comment 0 using an old Nightly build before the fix. Verified that using Firefox 113.0b8 across platforms (Windows 10, macOS 13 and Ubuntu 22.04) the issue does not reproduce anymore.

Status: RESOLVED → VERIFIED
status-firefox113: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: