Closed Bug 1820534 Opened 2 years ago Closed 2 years ago

Move front-end to modern flexbox.

Categories

(Core :: XUL, task)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- disabled
firefox113 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Regressed 1 open bug)

Details

Attachments

(2 files)

No description provided.

Done mostly automatically via find/replace following the conversions
specified here:

https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ

For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).

I opted for explicitly setting flex-grow/shrink on the flex="" attribute
rules since you might want to override flex-basis regardless.

I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).

Depends on: 1820634

FYI, this is post-soft-freeze material, but TB would need to change a few styles. Most of it should be search and replace, see commit message. -moz-box-ordinal-group: 0 needs to become order: -1 because order and -moz-box-ordinal-group have different initial values (0 vs. 1 respectively).

Flags: needinfo?(mkmelin+mozilla)

Thanks!

Flags: needinfo?(mkmelin+mozilla)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c25af897c9bc Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe

Backed out for causing causing reftests and mochitests failures.

  • Backout link
  • Push with failures
  • Failure Log mochitests
  • Failure Log reftests
  • Failure line mochitests: TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_tooltip.xhtml | hover tooltip with long unbreakable text tooltip is wrapped
  • Failure line reftests: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/box/flex-emulation-3.xhtml != layout/reftests/box/flex-emulation-3-notref.xhtml | image comparison, max difference: 0, number of differing pixels: 0
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99aa47505e15 Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Regressions: 1821304
Regressions: 1821333
Regressions: 1821340
Regressions: 1821355
Regressions: 1821376
Regressions: 1821387
Regressions: 1821395
Regressions: 1821404
Regressions: 1821410
Regressions: 1821330
Regressions: 1821412

emilio, maybe worth backing out, given the various regressions?

Flags: needinfo?(emilio)

The fixes are all one-liners, but still seems this should get a bit more bake time, so I'll prepare a patch to get it backed out of beta if that seems fine?

Flags: needinfo?(emilio)

(Backing out also makes TB have to back out and re-land their fixes so that's also slightly annoying... In retrospect I didn't expect this amount of regressions and should've waited to after the merge probably...)

Dianna, fyi, I chatted with Ryan and he told me he'd be fine with backout-right-after-the-merge. Just fyi, I can prepare the patch right after the merge happens.

Flags: needinfo?(dsmith)

thats fine with me, ill keep an eye out for backout patch next week.

Flags: needinfo?(dsmith)
Regressions: 1821548
Regressions: 1821636
Regressions: 1821647
Regressions: 1821657
Regressions: 1821678
Regressions: 1821871

(As promised)

Flags: needinfo?(dsmith)
Target Milestone: 113 Branch → 112 Branch

Comment on attachment 9322680 [details]
Backout of patch and follow-ups for beta.

Approved for 112.0b1

Attachment #9322680 - Flags: approval-mozilla-beta+
Blocks: 1822131
Regressions: 1822134
Regressions: 1822236

I don't know if you are aware of the possible very significant performance impact of your ongoing work?
We are seeing around 20% improvement in loading the style editor in the Browser Toolbox!
I imagine stylesheets are being displayed faster in the devtools UI thanks to modern flexbox being faster, or some change in styleeditor CSS which made it somehow faster.

== Change summary for alert #37603 (as of Thu, 09 Mar 2023 14:01:33 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
26% damp browser-toolbox.styleeditor-ready.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 772.08 -> 569.33
20% damp browser-toolbox.styleeditor-ready.DAMP windows10-64-shippable-qr e10s fission stylo webrender 627.05 -> 499.86
20% damp browser-toolbox.styleeditor-ready.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 626.85 -> 502.53
16% damp browser-toolbox.styleeditor-ready.DAMP macosx1015-64-shippable-qr e10s fission stylo webrender-sw 551.74 -> 461.53
8% damp custom.inspector.expandall.balanced windows10-64-shippable-qr e10s fission stylo webrender-sw 608.32 -> 557.39
6% damp custom.inspector.expandall.balanced windows10-64-shippable-qr e10s fission stylo webrender 601.38 -> 562.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=37603

Regressions: 1823791
Regressions: 1825050
Regressions: 1829549
Regressions: 1829695
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: