Stop/reload icon wiggles when you it switches between animated & static modes
Categories
(Core :: XUL, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox110 | --- | unaffected |
| firefox111 | --- | unaffected |
| firefox112 | --- | disabled |
| firefox113 | --- | verified |
People
(Reporter: dholbert, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
STR:
- Load (or reload) https://yahoo.com , or probably any non-trivially-sized site.
- Watch your stop/reload icon in your toolbar.
ACTUAL RESULTS:
The icon shifts rightwards a bit while it's animating, and then shifts left again. See attached screencast.
EXPECTED RESULTS:
No such shift.
Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=53491bc68f81d4c082d3d6cfdda617fe4deca8b0&tochange=c25af897c9bcb33045fe7664d93684de65cbf2a8
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Updated•2 years ago
|
|
Assignee | |
Comment 1•2 years ago
|
||
This behavior change I didn't see coming, I admit. This rule:
Used to be -moz-box-pack: center instead.
Which didn't have any effect on abspos behavior. Now it uses
justify-content: center, which (per spec) applies to abspos boxes as
well, and gives us the centering in the inline axis.
So that means we don't really need to apply the centering in the inline
axis manually, and that margin was only shifting our box to the right.
|
||
Updated•2 years ago
|
|
||
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1820534
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 3•2 years ago
|
||
I don't see any visible issue on the reload / stop buttons without this.
|
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9322346 [details]
Bug 1821548 - Remove BrowserUIUtils.setToolbarButtonHeightProperty and related code. r=Gijs
Revision D172238 was moved to bug 1821657. Setting attachment 9322346 [details] to obsolete.
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
|
||
Comment 7•2 years ago
|
||
This was backed out of beta v112 via bug 1820534
|
||
Updated•2 years ago
|
|
||
Comment 8•2 years ago
|
||
Reproduced using an old Nightly build before the fix, verified that using Firefox 113.0b8 across platforms (macOS 13, Windows 10, Ubuntu 22.04) the stop/reload icon does not wiggles anymore.
Description
•