Closed Bug 1821630 Opened 2 years ago Closed 2 years ago

misplaced system windows buttons to the right - macOS

Categories

(Thunderbird :: Toolbars and Tabs, defect)

Unspecified
macOS
defect

Tracking

(thunderbird_esr102 unaffected, thunderbird111 unaffected, thunderbird112 fixed)

RESOLVED FIXED
113 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird111 --- unaffected
thunderbird112 --- fixed

People

(Reporter: NicolasWeb, Assigned: Paenglab)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, ux-consistency, ux-natural-mapping, Whiteboard: [snnot3p])

Attachments

(2 files)

Actual results :
Since 112a1 build 20230309233507, the system windows buttons on macOS are misplaced to the right.

Expected results:
These windows system button should be placed to the left of the window

Regression: Okay in 102. Was okay with yesterday previous EN-US Dialy build

Status: NEW → UNCONFIRMED
Ever confirmed: false

Probably from modern flexbox (see bug 1821304)?

Keywords: regression
Whiteboard: [Supernova] → [snnot]

Regression from bug 1820744. It exchanged the -moz-box-ordinal-group: 0; into order: -1; instead of order: 0;.

Regressed by: 1820744

But that's the right thing to do, order: 0 is the initial value.

I tried it with 0 in inspector and it fixed the issue. Maybe it would be better to remove it to use the initial value.

Blocks: 1821304
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → 112 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/70c3859547b3
Don't use row-reverse for the unifiedToolbarContainer on macOS. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

We'd like to backout bug 1820744 from comm-beta 112.
Because this change here was made on top of the change from bug 1820744, I suggest to backout this one from 112, too.
Does anyone disagree?

Wayne gave approval on Matrix. I'll push the backout shortly.

Should anyone request to keep this on beta, we'll have to reland with merging (if that's even possible).

Target Milestone: 112 Branch → 113 Branch
Whiteboard: [snnot] → [snnot3p]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: