Move Thunderbird front-end to modern flexbox.
Categories
(Thunderbird :: Upstream Synchronization, task)
Tracking
(thunderbird_esr102 unaffected)
Tracking | Status | |
---|---|---|
thunderbird_esr102 | --- | unaffected |
People
(Reporter: mkmelin, Assigned: mkmelin)
References
(Regressed 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
+++ This bug was initially created as a clone of Bug #1820534 +++
Conversions are from https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ
Assignee | ||
Comment 1•2 years ago
|
||
* display: -moz-box -> display: flex
* -moz-box-flex: N -> flex-grow: N; flex-shrink: N
* -moz-box-align -> align-items:
* stretch -> stretch
* start -> flex-start
* center -> center
* baseline -> baseline
* end -> flex-end
* -moz-box-pack -> justify-content:
* start -> flex-start
* center -> center
* end -> flex-end
* justify -> space-between
* -moz-box-orient + -moz-box-direction -> flex-direction
* vertical + normal -> column
* vertical + reverse -> column-reverse
* horizontal + normal -> row
* horizontal + reverse -> row-reverse
* -moz-box-ordinal-group: N -> order: N
# display: -moz-box -> display: flex
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/display: ?-moz-box/display: flex/g" {} \;
# -moz-box-flex: N -> flex-grow: N; flex-shrink: N
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-flex: ?([0-9]+);/flex-grow: \1; flex-shrink: \1;/g" {} \;
# -moz-box-align -> align-items
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-align: start/align-items: flex-start/g" {} \;
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-align: end/align-items: flex-end/g" {} \;
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-align:/align-items:/g" {} \;
# -moz-box-pack -> justify-content:
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-pack: start/justify-content: flex-start/g" {} \;
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-pack: center/justify-content: center/g" {} \;
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-pack: end/justify-content: flex-end/g" {} \;
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-pack: justify/justify-content: space-between/g" {} \;
# -moz-box-orient + -moz-box-direction -> flex-direction
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-orient: vertical/flex-direction: column/g" {} \;
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-orient: horizontal/flex-direction: row/g" {} \;
## + one to manually fix at https://searchfox.org/comm-central/rev/1c667de681fc87d7050f21ddf33ec1ce652c9819/calendar/base/themes/common/calendar-preferences.css#60
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-direction: reverse;/flex-direction: row-reverse/g" {} \;
# -moz-box-ordinal-group: N -> order: N
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-ordinal-group: 0;/order: -1;/g" {} \;
find . -type f -not -path "*.hg/*" -not -path "./suite/*" -regex ".*\.\(html\|xhtml\|js\|css\)$" -exec sed -i -E "s/-moz-box-ordinal-group: ?([0-9]+);/order: \1;/g" {} \;
Comment 2•2 years ago
|
||
You also need dipsplay: -moz-inline-box
-> display: inline-flex
.
Also, fwiw, -moz-box-flex: N
can almost always be replaced by flex: N
or flex: N N
, which is a bit easier to read.
Updated•2 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/48fb708fdbf2
Move Thunderbird front-end to modern flexbox. r=freaktechnik
Comment 4•2 years ago
|
||
Things still broken after the patch:
- Today pane toggle day alignment is wrong
- The panel subview header is massive (open any submenu in the app menu)
- The chat conversation list action buttons are not correctly aligned
- Chat layout was behaving weird (seems ok atm), but it's been weird since flex emulation, so needs more work anyway
- Input sizes in chat account settings (authentication settings, default channels) is broken
I expect there's more that I didn't spot.
Assignee | ||
Updated•2 years ago
|
Comment 5•2 years ago
|
||
Magnus, bug 1820534 was backed out from beta 112 - can we back out this from beta, too?
(Keep on c-c 113 only.)
Comment 6•2 years ago
|
||
Wayne, do you agree to backout from comm-beta 112?
Please also approve backing out the following 4 additional bugs from comm-beta:
Comment 7•2 years ago
|
||
Wayne gave approval on Matrix. I'll push the backout shortly.
Assignee | ||
Comment 8•2 years ago
|
||
Thanks for handling!
Comment 9•2 years ago
|
||
Comment 10•2 years ago
|
||
backed out from 112, only, that is. adjusting milestone to 113.
Description
•