Closed Bug 1821920 Opened 2 years ago Closed 2 years ago

Items exceeding pane width in about:preferences#privacy panel

Categories

(Firefox :: Settings UI, defect, P1)

Firefox 112
defect

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- disabled
firefox113 --- fixed

People

(Reporter: wladow, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files)

We are seeing content-blocking-etp-standard-tcp-title label is exceeding panel width in latest Firefox Nightly Slovak builds (v112) while this isn't the case for Beta builds (v111) (see attached screenshots Firefox111_content-blocking-etp-standard-tcp-title.png vs. Firefox112_content-blocking-etp-standard-tcp-title.png). The string itself hasn't changed recently, so this seems to be a regression from other changes to the panel.

There are even more strings exceeding the width, see Firefox112_privacy_panel_more_strings_affected.png. The affected labels are cookie-banner-handling-description (added very recently in Bug 1820560, a suspect maybe?), the other label is forms-windows-sso

We are seeing this behaviour only in Privacy panel, the other Settings panels don't suffer from this.

FX112 build: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0, build 20230311212417

FX111 build: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/111.0, build 20230309232128

23:18.70 INFO: Narrowed integration regression window from [a064ca7f, c25af897] (4 builds) to [53491bc6, c25af897] (2 builds) (~1 steps left)
23:18.70 INFO: No more integration revisions, bisection finished.
23:18.70 INFO: Last good revision: 53491bc68f81d4c082d3d6cfdda617fe4deca8b0
23:18.70 INFO: First bad revision: c25af897c9bcb33045fe7664d93684de65cbf2a8
23:18.70 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=53491bc68f81d4c082d3d6cfdda617fe4deca8b0&tochange=c25af897c9bcb33045fe7664d93684de65cbf2a8
Severity: -- → S4
Keywords: regression
Regressed by: 1820534

:emilio, since you are the author of the regressor, bug 1820534, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)
Assignee: nobody → emilio

FWIW, for testing & fix-verification purposes: this regression reproduces in stock en-US Nightly. with the same privacy-preferences section that was screenshotted in comment 0, if you make your browser-window sufficiently skinny to force the bold string to wrap-or-overflow.

I also managed to reproduce / find the regression window by setting intl.l10n.pseudo to accented in about:config to get longer strings in that part of the UI.

Blocks: 1822131

Bug 1822131 will improve the situation here, but meanwhile this fixes the issue
by removing a redundant horizontal box.

Marking as P1, since we have an assignee and a patch in flight

Priority: -- → P1
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83863b1d086d Remove redundant <hbox> in privacy settings. r=Gijs,settings-reviewers
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

Set release status flags based on info from the regressing bug 1820534

Flags: qe-verify+

Reproduced the issue with Firefox 112.0a1 (2023-03-12) on macOS 12 and Windows 10.
The issue is verified fixed with Firefox 114.0a1 (20230426170915) and Firefox 113.0b8 (20230425192707) on Windows 10, macOS 12 and Ubuntu 22.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: