Closed Bug 1828623 Opened 1 year ago Closed 1 year ago

Nightly 114 snap builds failing since 2023-04-14

Categories

(Release Engineering :: Release Automation: Snap, defect)

defect

Tracking

(firefox-esr102 unaffected, firefox112 unaffected, firefox113 unaffected, firefox114 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr102 --- unaffected
firefox112 --- unaffected
firefox113 --- unaffected
firefox114 --- fixed

People

(Reporter: ke5trel, Assigned: stransky)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Snap builds are failing with the error The process '/usr/bin/sg' failed with exit code 2 since 2023-04-14.

https://github.com/canonical/firefox-snap/actions/workflows/nightly-build.yml

The actual error is at https://github.com/canonical/firefox-snap/actions/runs/4727567674/jobs/8388305251#step:6:26153:


107:45.07 widget/gtk/vaapitest
107:45.74 /root/parts/firefox/build/widget/gtk/vaapitest/vaapitest.cpp:202:17: error: no member named 'min' in namespace 'std'; did you mean 'fmin'?
107:45.75   numProfiles = std::min(numProfiles, maxProfiles);
107:45.75                 ^~~~~~~~
107:45.75                 fmin
107:45.75 /usr/include/x86_64-linux-gnu/bits/mathcalls.h:332:14: note: 'fmin' declared here
107:45.75 __MATHCALLX (fmin,, (_Mdouble_ __x, _Mdouble_ __y), (__const__));
107:45.75              ^
107:45.75 /root/parts/firefox/build/widget/gtk/vaapitest/vaapitest.cpp:221:22: error: no member named 'min' in namespace 'std'; did you mean 'fmin'?
107:45.75     numEntryPoints = std::min(numEntryPoints, maxEntryPoints);
107:45.75                      ^~~~~~~~
107:45.75                      fmin
107:45.75 /usr/include/x86_64-linux-gnu/bits/mathcalls.h:332:14: note: 'fmin' declared here
107:45.75 __MATHCALLX (fmin,, (_Mdouble_ __x, _Mdouble_ __y), (__const__));
107:45.75              ^
Flags: needinfo?(seb128)
Flags: needinfo?(bandali)

We don't have to use std::min/std::max here.

Assignee: nobody → stransky
Status: NEW → ASSIGNED
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/545902a5854e
[Linux] Don't use std::min in vaapitest r=emilio
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Clearing the needinfo from me since it seems it has been handled now

Flags: needinfo?(seb128)

Same.

Flags: needinfo?(bandali)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: