Closed
Bug 1830383
Opened 1 year ago
Closed 1 year ago
Implement "Thanks for your feedback" message in Suggest results.
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | verified |
People
(Reporter: adw, Assigned: adw)
References
()
Details
Attachments
(2 files)
screenshot
No description provided.
|
Assignee | |
Comment 1•1 year ago
|
||
This builds on D174994 and implements the "thanks for your feedback" message
shown inside a Suggest result when the user gives feedback on it without
dismissing it. This applies to weather suggestions, addons, Pocket, etc. The
implementation is very similar to the implementation of row/group labels.
References:
- Figma (see "A11y review - user feedback" in sidebar)
- Clickable prototype (see "Revised 4/3" in sidebar)
- Content design
Depends on D174994
|
||
Updated•1 year ago
|
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e03829064fb
Implement "Thanks for your feedback" message in Suggest results. r=dao,fluent-reviewers,flod
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
|
|
Assignee | |
Updated•1 year ago
|
Flags: qe-verify+
Flags: in-testsuite+
|
|
Assignee | |
Comment 4•1 year ago
|
||
STR for QA:
- Enable weather suggestions
- Trigger a suggestion
- Click the Feedback menu > Report inaccurate location
- Verify a "Thanks for your feedback" message appears in the suggestion, see screenshot
|
||
Comment 5•1 year ago
|
||
I have verified this issue on the latest Firefox Nightly 115.0a1 (Build ID: 20230508214159) and Beta 114.0b1 (Build ID: 20230508175934), on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.
- Clicking the “Report inaccurate location” will make the "Thanks for your feedback" message be displayed right under the weather result, on the left side of the panel.
- However, we noticed that the message in Figma shows that the text should end with a period punctuation mark, which is different from the actual UI. Can you please confirm which variant is the correct one?
Flags: needinfo?(adw)
|
|
||
Comment 6•1 year ago
|
||
As per Brent (@btrotter), the expected result should not include the period mark. Marking the task as Verified Fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(adw)
You need to log in
before you can comment on or make changes to this bug.
Description
•