Closed Bug 1841354 Opened 1 year ago Closed 1 year ago

The feedback acknowledgment remains when the row is reused

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed
firefox117 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1841354 - Always remove the feedback acknowledgment when a row is updated.
(deleted), text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details

The feedback acknowledgment can stick around when its row is reused for a different type of result. This hasn't been a problem until now, with Pocket suggestions, because before it's only been used for best matches, and best matches are practically never reused. I think we should just always remove it.

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b978ed538739 Always remove the feedback acknowledgment when a row is updated. r=dao

https://hg.mozilla.org/mozilla-central/rev/b978ed538739

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

Comment on attachment 9341998 [details]
Bug 1841354 - Always remove the feedback acknowledgment when a row is updated.

Beta/Release Uplift Approval Request

  • User impact if declined: This bug is necessary for the Pocket suggestions feature we intend to ship as an experiment in 116.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Two-line patch that only affects a small message shown in the urlbar UI. Only relevant to features that are not enabled by default. Covered by tests.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9341998 - Flags: approval-mozilla-beta?
Flags: qe-verify-
Flags: in-testsuite+

Comment on attachment 9341998 [details]
Bug 1841354 - Always remove the feedback acknowledgment when a row is updated.

Approved for 116.0b2

Attachment #9341998 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: