Closed Bug 1836903 Opened 1 year ago Closed 1 year ago

Implement Pocket suggestions

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This implements most parts of Pocket suggestions. They don't need any special UI
or a dynamic result type because they're only shown as the usual best match rows
or non-best match rows.

Still to do:

  • Implement the "Show less frequently" behavior once we decide what the keywords
    will be and how that will work.
  • Implement the bottom "Mozilla Pocket" text inside the suggestion row once it's
    finalized. We can use the same technique we use to show the "Sponsored" bottom
    text for adM suggestions.

Other changes this makes:

  • Replace the type=bestmatch attribute with an is-bestmatch attribute. That
    lets best-match rows have a type too, in this case "pocket" (actually
    either "rs_pocket" or "merino_pocket", since I'm using the telemetry
    result type).
  • Improve how UrlbarProviderQuickSuggest delegates to individual features when
    getting result commands, view updates, handling commands, etc., so that we
    don't need to add new case statements for each new type of suggestion.
Blocks: 1837096
Blocks: 1837097
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da3399f91bee Implement Pocket suggestions. r=daisuke,desktop-theme-reviewers,dao
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
Duplicate of this bug: 1832200
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: