Closed
Bug 1836903
Opened 1 year ago
Closed 1 year ago
Implement Pocket suggestions
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
116 Branch
Tracking | Status | |
---|---|---|
firefox116 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Assignee | ||
Comment 1•1 year ago
|
||
This implements most parts of Pocket suggestions. They don't need any special UI
or a dynamic result type because they're only shown as the usual best match rows
or non-best match rows.
Still to do:
- Implement the "Show less frequently" behavior once we decide what the keywords
will be and how that will work. - Implement the bottom "Mozilla Pocket" text inside the suggestion row once it's
finalized. We can use the same technique we use to show the "Sponsored" bottom
text for adM suggestions.
Other changes this makes:
- Replace the
type=bestmatch
attribute with anis-bestmatch
attribute. That
lets best-match rows have atype
too, in this case"pocket"
(actually
either"rs_pocket"
or"merino_pocket"
, since I'm using the telemetry
result type). - Improve how UrlbarProviderQuickSuggest delegates to individual features when
getting result commands, view updates, handling commands, etc., so that we
don't need to add newcase
statements for each new type of suggestion.
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da3399f91bee
Implement Pocket suggestions. r=daisuke,desktop-theme-reviewers,dao
Comment 3•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox116:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•