Once the plan for high- vs. low-confidence Pocket keywords is finalized, we need to implement the required matching logic and "Show less frequently" behavior.

Morphing this to cover only "Show less frequently". The keyword matching behavior is in bug 1841295.

Same as addon suggestions.

STR for QA:

1. Set browser.urlbar.pocket.featureGate = true to enable Pocket suggestions and browser.urlbar.bestMatch.enabled to enable best match
2. Type "breakfast" and verify a low confidence (non-top-pick) Pocket suggestion appears
3. Click the Feedback button and choose "Show less frequently" (If the button doesn't appear, try again after bug 1841409 lands)
4. Verify the "Thanks for your feedback" message appears in the suggestion
5. Clear the input and type "breakfast" again
6. Verify the suggestion does not appear
7. Repeat the above steps a few times by continuing to type search strings that match the full "breakfast casserole recipe" keyword. Each time you click "Show less frequently", you should have to type one more character than you did last time (including spaces). This bug does not implement a cap on the number of times you can click "Show less frequently", so the menu item will always appear, and you only need to do this a few times to verify it's working.

If you want to test a cap, then you can use a mock experiment that sets pocketShowLessFrequentlyCap: 3 (or any other number). You can also force enroll in the actual experiment itself (although it's in draft mode right now).

With this bug, the high confidence (top pick) suggestion also has the "Show less frequently" command but it shouldn't, so no need to test that now. We'll fix that later.

Comment on attachment 9341996 [details]
Bug 1837097 - Implement "Show less frequently" behavior for Pocket suggestions.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Pocket suggestions feature we intend to ship as an experiment in 116.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see STR in previous comment
• List of other uplifts needed: The following bugs must be uplifted first: 1841354, Bug 1841295, Bug 1841553, Bug 1841408, Bug 1841442
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects Pocket suggestions, which are disabled by default. Has tests.
• String changes made/needed:
• Is Android affected?: No

https://hg.mozilla.org/mozilla-central/rev/4f364c0d5be4

I have verified this issue on the latest Firefox Nightly 117.0a1 (Build ID: 20230706092222), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel (Firefox Suggest section) after typing the complete string (“breakfast”);
• The "Thanks for your feedback" message appears in the suggestion after clicking the “Show less frequently” option from the “Feedback” menu.
• The "Cat Cora" Pocket suggestion no longer appears when only typing “breakfast” alone as a keyword.
• The "Cat Cora" Pocket suggestion is displayed again after typing a new character (or space) from the full keyword ("breakfast casserole recipe").

Comment on attachment 9341996 [details]
Bug 1837097 - Implement "Show less frequently" behavior for Pocket suggestions.

Approved for 116.0b2

https://hg.mozilla.org/releases/mozilla-beta/rev/7a69b2c8f6ce

I have verified this issue on the latest Firefox Beta 116.0b2 (Build ID: 20230706193912), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel (Firefox Suggest section) after typing the complete string (“breakfast”);
• The "Thanks for your feedback" message appears in the suggestion after clicking the “Show less frequently” option from the “Feedback” menu.
• The "Cat Cora" Pocket suggestion no longer appears when only typing “breakfast” alone as a keyword.
• The "Cat Cora" Pocket suggestion is displayed again after typing a new character from the full keyword ("breakfast casserole recipe").