Closed Bug 1838041 Opened 1 year ago Closed 1 year ago

Display adjusted product star rating using FiveStarRating component from about:addons

Categories

(Firefox :: Shopping, task, P1)

task

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: jhirsch, Assigned: niklas)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-shopping])

Attachments

(1 file)

We will want to display a corrected five star rating for products in the sidebar.

It turns out there's already a FiveStarRating component used by the about:addons code.

Let's pull that component out into the reusable components in toolkit/content/widgets, and then reuse that component to render the star rating for shopping.

There should be some unit-y tests that check that the markup for a given API response is what we expect.

Whiteboard: [fidefe-shopping]
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P1
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/361e7d6f9080 Add moz-five-star reuseable component. r=shopping-reviewers,desktop-theme-reviewers,dao,fluent-reviewers,flod,robwu,mstriemer,kpatenio

Backed out for causing failures related to moz-five-star.css

[task 2023-06-22T20:23:20.079Z] 20:23:20     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-native-anonymous’.  Ruleset ignored due to bad selector." on resource://gre-resources/ua.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
[task 2023-06-22T20:23:20.079Z] 20:23:20     INFO - Buffered messages finished
[task 2023-06-22T20:23:20.080Z] 20:23:20     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for chrome://global/content/elements/moz-five-star.css: Unknown pseudo-class or pseudo-element ‘has’.  Ruleset ignored due to bad selector. - 
[task 2023-06-22T20:23:20.080Z] 20:23:20     INFO - Stack trace:
[task 2023-06-22T20:23:20.080Z] 20:23:20     INFO - chrome://mochikit/content/browser-test.js:test_ok:1580
[task 2023-06-22T20:23:20.080Z] 20:23:20     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:286
[task 2023-06-22T20:23:20.081Z] 20:23:20     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:556
[task 2023-06-22T20:23:20.081Z] 20:23:20     INFO - chrome://mochikit/content/browser-test.js:handleTask:1131
[task 2023-06-22T20:23:20.081Z] 20:23:20     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1203
[task 2023-06-22T20:23:20.081Z] 20:23:20     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1345
[task 2023-06-22T20:23:20.081Z] 20:23:20     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1120
[task 2023-06-22T20:23:20.081Z] 20:23:20     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1056
Flags: needinfo?(nbaumgardner)
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9a4950d4447 Add moz-five-star reuseable component. r=shopping-reviewers,desktop-theme-reviewers,dao,fluent-reviewers,flod,robwu,mstriemer,kpatenio
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch

In https://hg.mozilla.org/mozilla-central/rev/d9a4950d4447#l8.12 you're referring to a browser/ fluent file from toolkit/. This seems to be breaking some Thunderbird functionality. Can that be moved to toolkit?

Regressions: 1840086
Regressions: 1839844
Blocks: 1840180
No longer blocks: shopping2023
Regressions: 1840410
Flags: needinfo?(nbaumgardner)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: