toolkit/content/widgets/moz-five-star/moz-five-star.mjs references browser/components/mozFiveStar.ftl
Categories
(Firefox :: Shopping, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox-esr115 | --- | unaffected |
| firefox114 | --- | unaffected |
| firefox115 | --- | unaffected |
| firefox116 | --- | fixed |
People
(Reporter: robwu, Assigned: niklas)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-shopping])
Attachments
(2 files)
Reusable modules in toolkit should not reference Fluent files in browser/.
But moz-five-star.mjs loads browser/components/mozFiveStar.ftl at https://searchfox.org/mozilla-central/rev/d31e56f7b3c2c18b8071a7b2a2fb6b4e01e3d3e8/toolkit/content/widgets/moz-five-star/moz-five-star.mjs#8.
Consequently, Thunderbird broke (bug 1840086). As a work-around the file was copied to Thunderbird, but we should fix the issue by moving the ftl file to toolkit, I suppose to https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/toolkit. Make sure to add r=#fluent-reviewers to the patch, to verify whether there migration if any is correct.
Once this bug is fixed, the work-around from bug 1840086 can be reverted.
|
||
Comment 1•1 year ago
|
||
Set release status flags based on info from the regressing bug 1838041
:niklas, since you are the author of the regressor, bug 1838041, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
|
||
Updated•1 year ago
|
|
Assignee | |
Comment 2•1 year ago
|
||
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 3•1 year ago
|
||
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/comm-central/rev/ed4fdc3f75cd
Remove temporary mozFiveStar.ftl in mail. r=Paenglab
|
Reporter | |
Comment 5•1 year ago
|
||
The patch hasn't landed yet. What did land was just a revert of bug 1840086 ahead of landing the actual fix.
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
|
|
||
Comment 8•1 year ago
|
||
Set release status flags based on info from the regressing bug 1838041
|
|
Assignee | |
Updated•1 year ago
|
Description
•