Insert sidebar into the XUL DOM
Categories
(Firefox :: Shopping, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox117 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-shopping])
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
We created the basic chrome://browser/content/shopping/shopping.html page, now let's get it inserted into the XUL DOM.
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
The rough approach here is to insert the sidebar into the XUL DOM as a
shopping-sidebar
custom element with a url
attribute that is
observed by the component. On attribute update, the URL is relayed to
the shopping.html browser el by setting the url as its query string,
which causes the shopping page to reload. An onload listener in the
shopping page picks up the new product URL and can hand it off to the
API components when ready.
Does this approach make sense?
Note that I haven't yet styled the frame, but it's there.
I also haven't set up the actors yet--would it be better if the actors
instead manage sending down the URL?
Assignee | ||
Comment 2•1 year ago
|
||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Comment 4•1 year ago
|
||
Backed out for causing nightlyasrelease browsertime failures.
Failure logs:
- https://treeherder.mozilla.org/logviewer?job_id=421602144&repo=autoland
- https://treeherder.mozilla.org/logviewer?job_id=421593334&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/0e8e81c68d5f2b8d0058d18c9692c610f37b52bc
Assignee | ||
Comment 6•1 year ago
|
||
Thanks, sorry for the bustage. Think I've got it sorted this time.
Comment 7•1 year ago
|
||
bugherder |
Description
•