Closed Bug 1838438 Opened 1 year ago Closed 1 year ago

Insert sidebar into the XUL DOM

Categories

(Firefox :: Shopping, task, P2)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: jhirsch, Assigned: jhirsch)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-shopping])

Attachments

(1 file, 1 obsolete file)

We created the basic chrome://browser/content/shopping/shopping.html page, now let's get it inserted into the XUL DOM.

Assignee: nobody → jhirsch
Severity: -- → S3
Priority: -- → P1
Whiteboard: [fidefe-shopping]
Status: NEW → ASSIGNED

The rough approach here is to insert the sidebar into the XUL DOM as a
shopping-sidebar custom element with a url attribute that is
observed by the component. On attribute update, the URL is relayed to
the shopping.html browser el by setting the url as its query string,
which causes the shopping page to reload. An onload listener in the
shopping page picks up the new product URL and can hand it off to the
API components when ready.

Does this approach make sense?

Note that I haven't yet styled the frame, but it's there.

I also haven't set up the actors yet--would it be better if the actors
instead manage sending down the URL?

Attachment #9339066 - Attachment is obsolete: true
Priority: P1 → P2
Pushed by jhirsch@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27dfafd3d2a2 Insert shopping sidebar into the XUL DOM. r=mossop
Pushed by jhirsch@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ee0830a782d Insert shopping sidebar into the XUL DOM. r=mossop

Thanks, sorry for the bustage. Think I've got it sorted this time.

Flags: needinfo?(jhirsch)
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: