Closed Bug 1840852 Opened 1 year ago Closed 1 year ago

Update parent window code to use toolkit regex

Categories

(Firefox :: Shopping, task, P2)

Product:
Firefox
Component:
Shopping
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: jhirsch, Assigned: jhirsch)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-shopping])

Attachments

(1 file)

Bug 1840852 - Use shopping toolkit isProductURL check to decide whether to open the shopping sidebar. r?#shopping-reviewers
(deleted), text/x-phabricator-request
Details

In bug 1838438, we used a hacky demo regex to detect product pages.

Now that bug 1836741 has landed, we should instead check the regex using the toolkit code.

Blocks: shopping2023
Whiteboard: [fidefe-shopping]
Severity: -- → S3
Depends on: 1838438
Priority: -- → P2
Assignee: nobody → jhirsch
Status: NEW → ASSIGNED
Pushed by jhirsch@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d02cb9c7ec3 Use shopping toolkit isProductURL check to decide whether to open the shopping sidebar. r=shopping-reviewers,kpatenio

https://hg.mozilla.org/mozilla-central/rev/6d02cb9c7ec3

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: