Depends on D182634

STR for QA:

1. Set browser.urlbar.pocket.featureGate = true to enable Pocket suggestions and browser.urlbar.bestMatch.enabled to enable best match
2. Type "breakfast" and verify a low confidence (non-top-pick) Pocket suggestion appears
3. Verify the label above the suggestion is "Firefox Suggest"
4. Type "breakfast paninis" and verify a high confidence (top-pick) Pocket suggestion appears
5. Verify the label above the suggestion is "Recommended reads"

Comment on attachment 9342055 [details]
Bug 1841447 - Change the "Top pick" label to "Recommended reads" for Pocket suggestions.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Pocket suggestions feature we intend to ship as an experiment in 116.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see STR in previous comment
• List of other uplifts needed: The following bugs must be uplifted first: 1841354, Bug 1841295, Bug 1841553, Bug 1841408, Bug 1841442, Bug 1837097, Bug 1841446
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor string change to Pocket suggestions, which are disabled by default. Has tests.

Note: This patch modifies the Firefox Suggest FTL file, but the file is not localized. It is en-US only.

• String changes made/needed: None: This patch modifies the Firefox Suggest FTL file, but the file is not localized. It is en-US only.
• Is Android affected?: No

https://hg.mozilla.org/mozilla-central/rev/b87c580577d0

Comment on attachment 9342055 [details]
Bug 1841447 - Change the "Top pick" label to "Recommended reads" for Pocket suggestions.

Approved for 116.0b2

I have verified this issue on the latest Firefox Nightly 117.0a1 (Build ID: 20230706092222), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel after typing the complete string (“breakfast”). The label displayed above the suggestion is "Firefox Suggest".
• The "Your New Favorite Breakfast Sandwich is Anything but Basic" Pocket suggestion appears at the top of the Urlbar panel after typing the full keyword (“breakfast paninis”). The label displayed above the suggestion is "Recommended reads".

https://hg.mozilla.org/releases/mozilla-beta/rev/759d381f0fc9

I have verified this issue on the latest Firefox Beta 116.0b2 (Build ID: 20230706193912), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel after typing the complete string (“breakfast”). The label displayed above the suggestion is "Firefox Suggest".
• The "Your New Favorite Breakfast Sandwich is Anything but Basic" Pocket suggestion appears at the top of the Urlbar after typing the full keyword (“breakfast paninis”). The label displayed above the suggestion is "Recommended reads".