Closed Bug 1842160 Opened 1 year ago Closed 1 year ago

Missing labelled-by, label-for relationship with figures and their captions

Categories

(Core :: Disability Access APIs, defect)

Unspecified
Linux
defect

Tracking

()

VERIFIED FIXED
117 Branch
Tracking Status
firefox-esr102 --- wontfix
firefox-esr115 --- verified
firefox115 --- wontfix
firefox116 --- verified
firefox117 --- verified

People

(Reporter: jdiggs, Assigned: Jamie)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [ctw-23h2])

Attachments

(2 files)

Attached file figure.html (deleted) —

Steps to reproduce:

  1. Load the attached test case.
  2. Use an accessibility inspector (e.g. Accerciser) to view the accessible relations of figure and the figcaption elements.

Expected results: There would be a label-for relation on the figcaption pointing to the figure and a labelled-by relation on the figure pointing to the figcaption. See https://w3c.github.io/html-aam/#el-figcaption and https://w3c.github.io/html-aam/#el-figure.

Actual results: These relationships are missing.

Impact: Orca double-speaks the caption text.

Explanation: When caret navigation is used to move into a figure with a figcaption, Orca updates its location to the start of the figcaption's text and presents that text. However, because the user had moved from outside of the figure into it, Orca first presents the new ancestry which includes the figure, whose name is the same as the caption text. In order to not double-speak the text, Orca first checks to see if the name of the figure came from the caption text (i.e. as opposed to aria-label). And the way it performs this check is by looking for the labelled-by/label-for relation.

Ah. That totally makes sense. Sorry; I didn't think of relations when this was reported to us on Matrix, but I should have.

We do actually support these relations in LocalAccessible, but we aren't including them in the cache for RemoteAccessible. That means this regressed in Firefox 113.

Assignee: nobody → jteh
Blocks: orca, a11y-ctw
Severity: -- → S3
Keywords: regression
Regressed by: 1824293
Whiteboard: [ctw-23h2]
Pushed by jteh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7a73b6202373 Support the LABELLED_BY/LABEL_FOR relations on HTML figure/figcaption for RemoteAccessible. r=morgan
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

The patch landed in nightly and beta is affected.
:Jamie, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(jteh)

Comment on attachment 9343391 [details]
Bug 1842160: Support the LABELLED_BY/LABEL_FOR relations on HTML figure/figcaption for RemoteAccessible.

Beta/Release Uplift Approval Request

  • User impact if declined: Figure captions will be spoken twice by some screen readers, which is annoying for users.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Isolated change which only affects a11y label relations for figures/figcaptions. Covered by automated tests.
  • String changes made/needed:
  • Is Android affected?: No
Flags: needinfo?(jteh)
Attachment #9343391 - Flags: approval-mozilla-beta?
Attachment #9343391 - Flags: approval-mozilla-esr115?

Comment on attachment 9343391 [details]
Bug 1842160: Support the LABELLED_BY/LABEL_FOR relations on HTML figure/figcaption for RemoteAccessible.

Approved for 116.0b7

Attachment #9343391 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9343391 [details]
Bug 1842160: Support the LABELLED_BY/LABEL_FOR relations on HTML figure/figcaption for RemoteAccessible.

Approved for 115.1esr

Attachment #9343391 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
Flags: qe-verify+

Reproduced the issue on Firefox 117.0a1 (2023-07-07) on Ubuntu 22.04 by following the info provided in Comment 0 where Orca was reading twice the caption text from the testcase provided.

The issue is no longer reproducible on Firefox 115.1.0esr, Firefox 116.0 and Firefox 117.0a1 (2023-07-24) on the same system.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: