Open Bug 1844664 Opened 1 year ago Updated 1 year ago

Delete (trash icon) in message list does not work when using it from unified inbox folder

Categories

(Thunderbird :: Folder and Message Lists, defect)

Thunderbird 115
defect

Tracking

(thunderbird_esr115 affected)

Tracking Status
thunderbird_esr115 --- affected

People

(Reporter: dirk.reckeweg, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

Enabled "delete" in mail list
Clicked trash-icon in mail list

Actual results:

no action took place. Mail is still listed and available

Expected results:

Mail should be deleted

MacBook Pro
Apple M1 Pro
Ventura 13.4.1

I can't reproduce.
Do you have any add-on? Can you run Thunderbird in troubleshoot mode and see if it still happens?

Flags: needinfo?(dirk.reckeweg)

Only addon Provider for Google Calendar is installed.
Running in troubleshoot mode is fine.
Switching back to normal mode: runs fine

Several times closing the app and restart app: It happens again
I'm sorry but I cannot provide a reproducable "how to"

Flags: needinfo?(dirk.reckeweg)

What is the full version number of what you were using 5 days ago?

(In reply to Dirk from comment #0)

Enabled "delete" in mail list

So this is the delete column, correct?

no action took place. Mail is still listed and available

The message was both in the message list and in the message pane?

If you see this again using 115.0.1 or newer, please immediately check tools > developer > error console for relevant information

Component: Mail Window Front End → Folder and Message Lists
Flags: needinfo?(dirk.reckeweg)
Whiteboard: [closeme 2023-08-05]

(In reply to Wayne Mery (:wsmwk) from comment #4)

What is the full version number of what you were using 5 days ago?
115.0.1 (64 bit)
(In reply to Dirk from comment #0)

Enabled "delete" in mail list

So this is the delete column, correct?

yes

no action took place. Mail is still listed and available

The message was both in the message list and in the message pane?
Didn't matter. Also sometimes I used delete button in message area but the list wasn't refreshed.
If you see this again using 115.0.1 or newer, please immediately check tools > developer > error console for relevant information

ok

Flags: needinfo?(dirk.reckeweg)

This morning the problem happened again.

  • MacBook Pro 14" was in sleep mode for 2 days TB 115.0.1 still running
  • Click on trash icon in list didn't work
  • choosing right mousekey / delete message worked
  • afterwards click on trash icon was successfull
  • no immediate entries found in errorlog
    a few minutes later following error messages occurred:
    09:49:06.397
    NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgFolder.GetMessageHeader]
    restoreSelection chrome://messenger/content/about3Pane.js:4686
    onMessagesLoaded chrome://messenger/content/mailCommon.js:912
    _applyViewChanges resource:///modules/DBViewWrapper.jsm:1524
    set userTerms resource:///modules/SearchSpec.jsm:313
    updateSearch chrome://messenger/content/quickFilterBar.js:431
    deferredUpdateSearch chrome://messenger/content/quickFilterBar.js:398
    about3Pane.js:4697:17
    restoreSelection chrome://messenger/content/about3Pane.js:4697
    onMessagesLoaded chrome://messenger/content/mailCommon.js:912
    _applyViewChanges resource:///modules/DBViewWrapper.jsm:1524
    set userTerms resource:///modules/SearchSpec.jsm:313
    updateSearch chrome://messenger/content/quickFilterBar.js:431
    deferredUpdateSearch chrome://messenger/content/quickFilterBar.js:398
    09:49:06.517
    NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgFolder.GetMessageHeader]
    restoreSelection chrome://messenger/content/about3Pane.js:4686
    onMessagesLoaded chrome://messenger/content/mailCommon.js:912
    set searching resource:///modules/DBViewWrapper.jsm:922
    onSearchDone resource:///modules/SearchSpec.jsm:527
    about3Pane.js:4697:17
    restoreSelection chrome://messenger/content/about3Pane.js:4697
    onMessagesLoaded chrome://messenger/content/mailCommon.js:912
    set searching resource:///modules/DBViewWrapper.jsm:922
    onSearchDone resource:///modules/SearchSpec.jsm:527

(In reply to Dirk from comment #6)

  • Click on trash icon in list didn't work
  • choosing right mousekey / delete message worked
  • afterwards click on trash icon was successfull

I'm confused by these steps.

After step 2 above, isn't the message already gone?
If you have already deleted the message, how are you able to click the row's trash icon in step 3?

Flags: needinfo?(dirk.reckeweg)

Are you referring to the trash icon in the message row in the message list?

Or are you referring to a toolbar icon outside the message list?

(In reply to Kai Engert (:KaiE:) from comment #7)

(In reply to Dirk from comment #6)

  • Click on trash icon in list didn't work
  • choosing right mousekey / delete message worked
  • afterwards click on trash icon was successfull

I'm confused by these steps.

After step 2 above, isn't the message already gone?

yes, the message is gone

If you have already deleted the message, how are you able to click the row's trash icon in step 3?

sorry for causing confusion: It was then possible to deleted a different message by clicking the trash icon in the list

Flags: needinfo?(dirk.reckeweg)

(In reply to Kai Engert (:KaiE:) from comment #8)

Are you referring to the trash icon in the message row in the message list?

yes

Or are you referring to a toolbar icon outside the message list?

no

Do you run two email clients in parallel, that are both connected to the same email account?

Is it possible that the issue happens with emails that you have already deleted in a different email client?

(which I guess would be even more confusing, because TB should automatically detect if an email was already deleted on the server)

Was "click on trash icon" the very first action that you performed with Thunderbird after waking up the machine from sleep?

Maybe on the initial click, Thunderbird tried to use a network connection that was stale and gone, because of sleeping?

I'm looking at the code that's referenced in the stack from comment 6.
The interesting place is in about3Pane.js - and it's noteworthy that this file has changed after version 115.0.1 (the version the user was using).

We fail on this line:
// The message for this key can't be found. Perhaps the thread it's in
// has been collapsed? Select the root message in that case.
try {
-> let msgHdr = gFolder.GetMessageHeader(key);

So the code had already concluded that the selected message cannot be found.
The fallback code here attempts to use the selected key to find its header, but that doesn't work either. Does that fallback code make sense?

We already have a commit related to this code here:
https://hg.mozilla.org/releases/comm-esr115/rev/3b0756a31dd45922bf53d538b478ac7fff72050b

It might be useful to wait for Dirk's experiences with 115.1

Possibly related to bug 1840007 ?

Status: UNCONFIRMED → NEW
Ever confirmed: true

(In reply to Kai Engert (:KaiE:) from comment #11)

Do you run two email clients in parallel, that are both connected to the same email account?

yes, but not on the same computer. One client on Mac, one on Android phome, one on Android tablet

Is it possible that the issue happens with emails that you have already deleted in a different email client?

(which I guess would be even more confusing, because TB should automatically detect if an email was already deleted on the server)

no, this happens when all the sync staff is done

(In reply to Kai Engert (:KaiE:) from comment #12)

Was "click on trash icon" the very first action that you performed with Thunderbird after waking up the machine from sleep?

I think so. I wait until the sync with my 5 mail providers is finnished. Then I start with cleaning up mails, deleting those ones from list I don't want to read. Most often, when I place the mouse over the delete icon in list the icon turns to red and the tooltip is shown, but the click is ignored

Maybe on the initial click, Thunderbird tried to use a network connection that was stale and gone, because of sleeping?

I don't know but this behaviour continues even after several syns are done. I first have to use right mouse key / delete message and afterwards I can delete other messages from list by clickung on trash icon in list

I just updated to version 115.1 but the problem continues.
BUT: I just found that this missbehaviour only seems to occur in the "general inbox" showing all the inboxes of 5 providers!
When switching to a specific inbox deleting a mail by clicking on trash icon works!
Switching back to "general inbox" the problem continues.

After upgrading to version 115.1 I rebooted my mac and started Thunderbird. The error console shows the following:
14:15:53.695 While creating services from category 'app-startup', service for entry 'OS Integration', contract ID '@mozilla.org/messenger/osintegration;1' does not implement nsIObserver.
14:15:53.770 1690978553770 addons.xpi WARN Checking /Applications/Thunderbird.app/Contents/Resources/distribution/extensions for addons
14:15:54.255 Calendar: [CalICSService] Error in parser worker: [object Object] CalICSService.jsm:592
14:15:54.255 Calendar: Error Parsing ICS: 2147500037 CalIcsParser.jsm:145
14:15:54.441
Assert failed: Calendar manager initialised calendars before loadCalendarComponent ran on the first 3pane window. This should not happen.
calUtils.jsm:127:15
ASSERT resource:///modules/calendar/calUtils.jsm:127
loadCalendarComponent chrome://calendar/content/calendar-chrome-startup.js:39
_loadComponentsAtStartup chrome://messenger/content/messenger.js:394
_delayedStartup chrome://messenger/content/messenger.js:384
14:15:54.450 Found 0 public keys and 0 secret keys (0 protected, 0 unprotected) RNPLib.jsm:551:15
14:15:54.502 services.settings: Failed to load last_modified.json: TypeError: NetworkError when attempting to fetch resource. Utils.sys.mjs:322
14:15:54.547 While creating services from category 'app-startup', service for entry 'OS Integration', contract ID '@mozilla.org/messenger/osintegration;1' does not implement nsIObserver.
14:16:00.086 Trying to load /Applications/Thunderbird.app/Contents/MacOS/libotr.dylib OTRLib.sys.mjs:65:11
14:16:00.212 Successfully loaded OTR library /Applications/Thunderbird.app/Contents/MacOS/libotr.dylib OTRLib.sys.mjs:73:13
14:16:01.247 Calendar: Error: Property DESCRIPTION not set
setPropertyParameter resource:///components/calItemBase.js:548
getAdditionalDataForItem resource:///modules/calendar/CalStorageItemModel.jsm:847
handleResultInner resource:///modules/calendar/CalStorageDatabase.jsm:236
handleResult resource:///modules/calendar/CalStorageDatabase.jsm:230
CalStorageDatabase.jsm:250
14:16:01.429 Calendar: Error: Property DESCRIPTION not set
setPropertyParameter resource:///components/calItemBase.js:548
getAdditionalDataForItem resource:///modules/calendar/CalStorageItemModel.jsm:847
handleResultInner resource:///modules/calendar/CalStorageDatabase.jsm:236
handleResult resource:///modules/calendar/CalStorageDatabase.jsm:230
CalStorageDatabase.jsm:250
14:17:52.503
NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgFolder.GetMessageHeader]
restoreSelection chrome://messenger/content/about3Pane.js:4731
_onSelect chrome://messenger/content/about3Pane.js:2406
handleEvent chrome://messenger/content/about3Pane.js:1511
set selectedRow chrome://messenger/content/tree-listbox.js:481
_onClick chrome://messenger/content/tree-listbox.js:106
handleEvent chrome://messenger/content/tree-listbox.js:76
about3Pane.js:4742:17
restoreSelection chrome://messenger/content/about3Pane.js:4742
_onSelect chrome://messenger/content/about3Pane.js:2406
handleEvent chrome://messenger/content/about3Pane.js:1511
set selectedRow chrome://messenger/content/tree-listbox.js:481
_onClick chrome://messenger/content/tree-listbox.js:106
handleEvent chrome://messenger/content/tree-listbox.js:76

I just found that this missbehaviour only seems to occur in the "general inbox" showing all the inboxes of 5 providers!

Ah, so you're using the Unified folder mode?

(In reply to Alessandro Castellani [:aleca] from comment #18)

I just found that this missbehaviour only seems to occur in the "general inbox" showing all the inboxes of 5 providers!

Ah, so you're using the Unified folder mode?

yes

All right, this is important if it never happens in a normal folder.
I still can't reproduce this unfortunately.

Summary: Delete (trash icon) in list does not work → Delete (trash icon) in message list does not work when using it from unified inbox folder

This reproduces for me with 117.0b4.

Identify a message and click the trash icon in the unified Inbox message list - nothing happens and nothing in error console. It should work whether the message is selected or not.

Now open the message list for the accounts Inbox, click the trash icon and the message is deleted.

Blocks: sn-msglist
Keywords: regression
Whiteboard: [closeme 2023-08-05]
You need to log in before you can comment on or make changes to this bug.