Closed Bug 184703 Opened 22 years ago Closed 16 years ago

Better way of setting |isPre| parameters.

Categories

(Core :: CSS Parsing and Computation, defect, P1)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: dbaron, Unassigned)

References

Details

bz suggested in bug 1777 comment 226 that we should have a method on the style struct that tests whether whitespace is PRE or PRE_WRAP. This would simplify a bit of code. When doing this, I should also correct the XXX comment cited in that comment by walking up to the closest block (unless we want to change our implementation of the 'white-space' property to apply to inlines as well).
There's also code in Inspector that could use the new function on the style struct...
This should take into account the CSS3 text properties, which will split white-space into a gazillion different axes.
Of course, we won't need the parameter once 'white-space' applies to all elements rather than just blocks, which I think is a CSS 2.1 change.
Status: NEW → ASSIGNED
Priority: -- → P1
Depends on: 191699
Assignee: dbaron → nobody
Status: ASSIGNED → NEW
QA Contact: ian → style-system
This is all fixed now. See particularly bug 191699, bug 261081, maybe bug 393096, although there were other pieces (including a big patch from roc that I can't find).
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.