Closed
Bug 261081
Opened 20 years ago
Closed 17 years ago
Add support for pre-wrap value of white-space
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9beta4
People
(Reporter: hugoh, Assigned: roc)
References
(Blocks 1 open bug, )
Details
(Keywords: css2, dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040914 Firefox/0.9
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040914 Firefox/0.9
Mozilla supports "white-space: -moz-pre-wrap", which is proprietary, and not the
CSS 2 property "white-space: pre-wrap", which is equivalent.
Could it be added?
Thank you.
Regards,
Hugo
Reproducible: Always
Steps to Reproduce:
Comment 1•20 years ago
|
||
*** This bug has been marked as a duplicate of 230555 ***
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Updated•20 years ago
|
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Comment 2•20 years ago
|
||
See also bug 230555.
Updated•20 years ago
|
Blocks: line-breaking
Comment 3•20 years ago
|
||
s/CSS 2/CSS2.1/
-->Accept, should be as simple as changing all in-source uses from -moz- to
normal use.
Dbaron, should I keep backwards compat somehow with current version, for
websites which used it, similar to how we kept backwards compat with -moz-opacity ?
Assignee: dbaron → 116057
No longer blocks: line-breaking
Updated•20 years ago
|
Blocks: line-breaking
Comment 4•20 years ago
|
||
More needs to be done than just renaming. We first need to make sure it does
what the spec says.
Assignee: 116057 → dbaron
Updated•20 years ago
|
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Comment 5•19 years ago
|
||
*** Bug 330706 has been marked as a duplicate of this bug. ***
Updated•18 years ago
|
Flags: blocking1.9?
Updated•18 years ago
|
Flags: blocking1.9? → blocking1.9-
Whiteboard: [wanted-1.9]
Updated•18 years ago
|
QA Contact: ian → style-system
Assignee | ||
Comment 6•17 years ago
|
||
I think we'll be looking good for this when I'm done with bug 393096
Depends on: 393096
Assignee | ||
Comment 7•17 years ago
|
||
I think we should do this now. Our white-space:-moz-pre-wrap handling has improved a lot and is now very good IMHO.
Assignee | ||
Comment 8•17 years ago
|
||
This should do it.
We could give -moz-pre-wrap its own value so that getComputedStyle and readers of style.whiteSpace can still return "-moz-pre-wrap", but I don't think that should be necessary.
There are a lot of uses of -moz-pre-wrap in stylesheets in our tree, which could be replaced in a separate patch.
I did some testing and found bug 411792, which should be fixed before we land this.
Assignee: dbaron → roc
Status: NEW → ASSIGNED
Attachment #296444 -
Flags: superreview?(dbaron)
Attachment #296444 -
Flags: review?(dbaron)
Assignee | ||
Updated•17 years ago
|
Flags: wanted1.9+
Whiteboard: [wanted-1.9]
Comment 9•17 years ago
|
||
Comment on attachment 296444 [details] [diff] [review]
fix?
r+sr=dbaron.
I tend to think you should just remove -moz-pre-wrap (from nsCSSProps.cpp and nsCSSKeywordList.h).
Could you add pre-wrap to layout/style/test/property-database.js too ?
Attachment #296444 -
Flags: superreview?(dbaron)
Attachment #296444 -
Flags: superreview+
Attachment #296444 -
Flags: review?(dbaron)
Attachment #296444 -
Flags: review+
Assignee | ||
Comment 10•17 years ago
|
||
> Could you add pre-wrap to layout/style/test/property-database.js too ?
OK
> I tend to think you should just remove -moz-pre-wrap (from nsCSSProps.cpp and
> nsCSSKeywordList.h).
We use it all over the place in our tree. I could do a big search-and-replace, but extensions may also use it, not to mention actual Web sites. Can we not do this in 1.9? I think it's polite to have a transition period with both are supported.
Comment 11•17 years ago
|
||
OK, fine to keep -moz-pre-wrap for 1.9 given how close to release we are, but file a bug on removing it afterwards.
Assignee | ||
Comment 12•17 years ago
|
||
Comment on attachment 296444 [details] [diff] [review]
fix?
For a long time we've supported CSS "white-space:-moz-pre-wrap" but it was too buggy to officially support it as "white-space:pre-wrap". Now, thanks to all the text work in 1.9, we think it's ready to enable via "pre-wrap"; that's all this patch does.
The patch looks big but it's actually quite simple. The risk is that Web sites using "pre-wrap" might be broken by this change.
Attachment #296444 -
Flags: approval1.9?
Comment 13•17 years ago
|
||
Comment on attachment 296444 [details] [diff] [review]
fix?
Thnx for the backgroun Roc
Attachment #296444 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 14•17 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago → 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Assignee | ||
Comment 15•17 years ago
|
||
filed bug 418543 on removing -moz-pre-wrap.
Updated•17 years ago
|
Keywords: dev-doc-needed
Comment 16•17 years ago
|
||
This is already documented, marking as doc complete.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•