Closed Bug 187790 Opened 22 years ago Closed 22 years ago

document.write doesn't write outside of the body (frames / frameset blank)

Categories

(Core :: DOM: HTML Parser, defect, P1)

Product:
Core
Component:
DOM: HTML Parser
Platform:
x86
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.3beta

People

(Reporter: svl-bmo, Assigned: harishd)

References

(
URL
)

Details

(Keywords: regression, topembed, Whiteboard: [fix in hand])

Attachments

(3 files, 1 obsolete file)

basic testcase
(deleted), text/html
Details
patch v1.1
(deleted), patch
hjtoi-bugzilla
: review+
jst
: superreview+
Details | Diff | Splinter Review
for the picky, a fully valid HTML 4.01 Strict testcase that this bug breaks
(deleted), text/html
Details
This regressed between 2002122805 and 20030105. http://delfi.library.tudelft.nl:4505/ALEPH/-/start/tud01 writes a frameset using javascript; current build doesn't show anything on the page. I've created a reduced testcase (will attach momentarily) - apparently document.write outside of the <body> has stopped working. I'm seeing this on windows, on irc wolruf confirmed that the same is happening on linux. The same is occurring on http://www.airfrance.fr/ => critical.
possible culprit: bug 42945 ?
Attached file basic testcase (deleted) —
2003010205 still works. Might be a regression from bug 42945
This regressed between 2003-01-02-22 and 2003-01-03-21. The only checkina that looks relevant in that date range are bug 42945 and bug 182021
Assignee: jst → harishd
Component: DOM Level 0 → Parser
Flags: blocking1.3b?
QA Contact: desale → moied
BTW, note the drastic effect on attachment 110033 [details] to bug 186465.
*** Bug 187895 has been marked as a duplicate of this bug. ***
*** Bug 186838 has been marked as a duplicate of this bug. ***
Will look.
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.3beta
This is a regression caused by bug 182021; open head counter got messed up!
Attached patch patch v1.0 (obsolete) (deleted) — — Splinter Review
Patch to make sure that the head context is closed before dealing with tags that belong in the body/frameset.
Sander: Thanks for the testcase.
Whiteboard: [fix in hand]
Attached patch patch v1.1 (deleted) — — Splinter Review
This patch passes parser regression test; had to put back a few lines of code, in CNavDTD::WillHandleStartTag, that I thought could be removed.
Attachment #110828 - Attachment is obsolete: true
*** Bug 188011 has been marked as a duplicate of this bug. ***
*** Bug 188003 has been marked as a duplicate of this bug. ***
*** Bug 188052 has been marked as a duplicate of this bug. ***
Could reporter or owner add JS javascript to short desc to prevent duplications?
http://www.jacintaportugal.com/press.html started to show only blank page on 06 nightly... could it be same problem? uses document.write to write self referencing frameset thx
Summary: document.write doesn't write outside of the body → document.write doesn't write outside of the body (frames / frameset blank)
Attachment #110840 - Flags: superreview?(jst)
Attachment #110840 - Flags: review?(heikki)
Comment on attachment 110840 [details] [diff] [review] patch v1.1 - In badscript.html: <head> <title>script test</title> <script> - <!-- - document.write("</script>"); document.write("hello there"); - //--> </script> This change makes this no longer be 'badscript.html' doesn't it? Do we now handle the current badscript.html differently than with this patch? sr=jst, if the above is dealt with.
Attachment #110840 - Flags: superreview?(jst) → superreview+
>This change makes this no longer be 'badscript.html' doesn't it? Do we now >handle the current badscript.html differently than with this patch? That was unintentional. Basically, that testcase failed with patch v1.0 and I was tweaking the testcase to find out the problem. Thanks for catching it.
http://www.o45m.ru/ Is this site a same problem? In moz it does not shown anymore, but is ok in NN7.01. It had also worked in november mozilla builds.
Additional info for my above comment: I opened a bug http://bugzilla.mozilla.org/show_bug.cgi?id=179756 and the site worked on moz 2002110408, so it regressed after that build.
Eugene: Yes, that site is creating a frameset with javascript. Just look at the source.
Yes, but that site regressed when I viewed it in some of mozillas begining detsember builds. In this bug are dates about very late detsember...
*** Bug 188110 has been marked as a duplicate of this bug. ***
*** Bug 188176 has been marked as a duplicate of this bug. ***
I can confirm this bug since late december builds. Here two main Website pages that should show up with JavaScript builded framesets on a bit different ways: http://www.deutsche-bank.de/pbc/index.html http://www.hannover-rueck.de (maybe: http://www.hannover-rueck.de/HannoverRe/German+Version)
naive question: could someone produce an example or testcase of this bug wich can be validated by W3C?
Attachment #110840 - Flags: review?(heikki) → review+
*** Bug 188256 has been marked as a duplicate of this bug. ***
Keywords: topembed
*** Bug 188279 has been marked as a duplicate of this bug. ***
*** Bug 188381 has been marked as a duplicate of this bug. ***
Fixed
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Flags: blocking1.3b?
still don't work in 2003010908 for me
Yves: I landed the fix today. Please test with tomorrow's build.
*** Bug 188501 has been marked as a duplicate of this bug. ***
I tried build 2003011004 and it works for me. :) Thanks! :)
*** Bug 188599 has been marked as a duplicate of this bug. ***
*** Bug 188470 has been marked as a duplicate of this bug. ***
*** Bug 188661 has been marked as a duplicate of this bug. ***
*** Bug 188471 has been marked as a duplicate of this bug. ***
*** Bug 188791 has been marked as a duplicate of this bug. ***
*** Bug 188844 has been marked as a duplicate of this bug. ***
*** Bug 188281 has been marked as a duplicate of this bug. ***
*** Bug 189494 has been marked as a duplicate of this bug. ***
WFM with current build. no new dupes for a while. verifying fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: