In a few locations in DOM Inspector code, Inspector uses the prompt() method to implement commands. This is bad, according to timeless. The URL field above has a particularly bad UI for inserting attributes -- it uses prompt() twice before executing the command. Steps to reproduce: (1) Left panel to DOM Nodes, right panel to DOM Node (2) Right-click in attributes panel (the white area) and activate Insert option. (3) Enter attribute qualified name and hit OK. (4) A dialog box for attribute value appears. The proper fix for this will require another bug be fixed, which I will file in a moment.

There are three files where prompt resides. I've fixed two of them (inspector.js and domNode.js) without any trouble. The styleRules.js file uses prompts as well. But unlike the others, it doesn't seem to recognize the command object structure other panels observe. caillon: you have a bug to rewrite how Inspector accesses style rules. Will that rewrite include undo/redo?

I'll have to wait on feedback before I try styleRules.js fixing.

Comment on attachment 119625 [details] [diff] [review] patch for files other than styleRules.js >+++ extensions/inspector/resources/content/inspector.js Sat Mar 15 >+ window.openDialog("chrome://inspector/content/showOpenURLDialog.xul", "", >+ "chrome, width=320, height=80, modal=1", this); Someone who actually knows openDialog() should review the args being passed here (timeless? Neil?)... that said, I'd think that you would want to specify the sizes in the dialog itself, not in the caller. Why name it "showOpenURLDialog.xul" instead of "openURLDialog.xul"? Finally, is that XUL file being added? If so, you want to upload it... ;) >+++ extensions/inspector/resources/content/viewers/domNode/domNode.js >+ isInStack: false, How is this relevant to this bug? Add a comment saying what this member does? >+ window.openDialog("chrome://inspector/content/viewers/domNode/insertAttrDialog.xul", "Insert Attribute", >+ "chrome, modal=1, width=320, height=160", this); Same comments as on the openDialog() call above.

Hehe, not providing the dialog box XUL... oops. And for not including the jar.mn changes. isInStack relates to the necessity of separating command execution from automatically inserting into the stack (bug 193726). I'll get back to you on the rest.

Wontfix per my discussion with weirdal earlier. If there are any UI issues that you still feel should be addressed, please file them as a different bug.

Filed bug 205872 for domNode.js dual-prompting for attributes. That should be a single dialog box.