Closed Bug 196036 Opened 22 years ago Closed 13 years ago

Add junk mail status to search/filter criteria

Categories

(MailNews Core :: Filters, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 198100

People

(Reporter: david, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Please make 'junk mail' a searchable criteria
I think this will be solved when bug 195737 is fixed. Then you can make a customized filter or it can be added in the predefined list.
mass re-assign.
Assignee: naving → sspitzer
Updating this bug to an enhancement request, moving component to Filters -- being able to ID mail as junk during filter execution is as desirable as during Search operation. See bug 202605.
Severity: normal → enhancement
Component: Search → Filters
OS: Linux → All
Hardware: PC → All
Summary: Add junk mail status to search criteria → Add junk mail status to search/filter criteria
Blocks: 202605
Depends on: 223591
*** Bug 220716 has been marked as a duplicate of this bug. ***
*** Bug 264958 has been marked as a duplicate of this bug. ***
Product: MailNews → Core
Attached patch Enable junk filters (obsolete) (deleted) — Splinter Review
This patch enables 3 things: 1) Junk Status in IMAP online searches, using the Imap Keyword search term 2) Has Attachment in offline filters, since bug #241203 makes that information available now 3) Junk Status in offline filters, which still depends on a solution to bug #223591 Let me know if this should be split apart. It's still trivial, regardless.
Attached patch Fix missing lines in prev... (obsolete) (deleted) — Splinter Review
Accidentally deleted some lines.
Attachment #184232 - Attachment is obsolete: true
Attached patch Fix IMAP online junk search (deleted) — Splinter Review
IMAP online junk search actually works in this one.
Attachment #184233 - Attachment is obsolete: true
Attachment #184236 - Flags: review?(bienvenu)
Blocks: 105169
Blocks: 83969
No longer blocks: 105169
(In reply to comment #6) > This patch enables 3 things: > 1) Junk Status in IMAP online searches, using the Imap Keyword search term > 2) Has Attachment in offline filters, since bug #241203 makes that > information available now I split the Has Attachment patch off on its own, and moved it to bug 105169 where it belongs.
No longer blocks: 83969
Status: NEW → ASSIGNED
Comment on attachment 184236 [details] [diff] [review] Fix IMAP online junk search sorry it took so long - I forgot about this. What worries me about this patch is that when filters run, we don't know if a message is junk or not, since filters run before we classify messages as junk or non-junk. So it would be misleading if we put that in the UI for incoming mail filters, right?
(In reply to comment #10) > (From update of attachment 184236 [details] [diff] [review] [edit]) > sorry it took so long - I forgot about this. What worries me about this patch > is that when filters run, we don't know if a message is junk or not, since > filters run before we classify messages as junk or non-junk. So it would be > misleading if we put that in the UI for incoming mail filters, right? > Yes, you're right. This is really blocked by the work on putting junk classification into the filter engine, we can't move ahead with this patch until the other part is completed.
Comment on attachment 184236 [details] [diff] [review] Fix IMAP online junk search I'm going to clear the review request until this patch is unblocked...
Attachment #184236 - Flags: review?(bienvenu)
*** Bug 321796 has been marked as a duplicate of this bug. ***
Assignee: sspitzer → nobody
Status: ASSIGNED → NEW
QA Contact: laurel → filters
*** Bug 356099 has been marked as a duplicate of this bug. ***
*** Bug 349659 has been marked as a duplicate of this bug. ***
Product: Core → MailNews Core
Junk mail status is already a searchable attribute. For filters, I have now submitted a patch to bug 198100, which allows filters to be applied after the junk processing. This exposes junk status as a filterable attribute for incoming filters, which is new. AFAICT, that meets all of the requirements of this bug. So I am tempted to dupe this bug to bug 198100. Any objections?
Whiteboard: [dupeme]
So let's try it.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Whiteboard: [dupeme]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: