Closed
Bug 196236
Opened 22 years ago
Closed 21 years ago
no help text for junk mail controls pane
Categories
(Documentation Graveyard :: Help Viewer, defect)
Documentation Graveyard
Help Viewer
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: james.davis, Assigned: danielwang)
References
()
Details
Attachments
(2 files, 4 obsolete files)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030306
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030306
The text in the "Using Junk Mail Controls" is simply "text to come".
Hope this will be filled out a bit more before 1.3 is gold.
Reproducible: Always
Steps to Reproduce:
1.Mail, Tools, Junk Mail Controls, Help
2.
3.
Comment 1•22 years ago
|
||
Mozilla 1.3b, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b)
Gecko/20030210, Windows XP Pro, Build 2600.xpsp1.020828-1920
Confirmed in 1.3b. Hardware/OS should be changed...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•22 years ago
|
||
-> doc:user
Assignee | ||
Comment 4•22 years ago
|
||
check out bug 197991 attachment 120929 [details])
Assignee | ||
Comment 5•21 years ago
|
||
edited from from ver 1.16 .
cvs diff is not working. I think it's probably the file wasn't saved in unix
text file format. so I post the entire html instead.
Assignee | ||
Updated•21 years ago
|
Attachment #132226 -
Flags: superreview?(dveditz+bmo)
Attachment #132226 -
Flags: review?(rlk)
Comment 7•21 years ago
|
||
Daniel, is this all the changes you made? There was a lot of garbage in the
patch, so I might of deleted something by accident.
Attachment #132226 -
Attachment is obsolete: true
Updated•21 years ago
|
Attachment #132226 -
Flags: superreview?(dveditz+bmo)
Attachment #132226 -
Flags: review?(rlk)
Comment 8•21 years ago
|
||
Comment on attachment 132228 [details] [diff] [review]
Daniel's changes.
> +how to protect yourself from Spammers.</p>
hmm. Do we want to use this wording?
> +Then, you let it autoclassify new mail for you, and you continue
> +to correct it as it makes mistakes.</p>
How about this:
Then, you let it autoclassify new mail for you. If Mozilla makes any mistakes,
you can correct them.
This sentence looks a little long to me.
> + listing, watch it catch messages that contain the klez virus
Let's not list specific viruses. Just say "catch messages that might contain a
virus."
> +<p>Besides using Junk Mail Controls, you can also use
> +<a href="#sender_filter">filters</a> to prevent junk mail.</p>
Although this may be true, I don't think that filters are commonly used for
junk mail purposes. Should we really show them here? This is an opinionated
thing, so if you don't agree with me, that's fine.
> + <li><b>Enable Junk Mail Controls</b>: Toggle this option to activate or
Can we try and use <strong> tags instead of <b>?
> + <li><p><b>Move incoming messages determined to be junk mail to</b>:
What the? Why is there a <p> tag in a <li> tag? Very bad!
> + <li><b>Automatically delete junk messages older than</b> XX <b>days from
Just a picky thing, but let's just have one X.
> +<div class="boilerplate">
> +The following information is provided by mozilla.org for
Shouldn't this be at the top of the document? We shouldn't have this in the
middle.
> +<q>spammers lie</q> and do not follow the instructions; your reply
change "follow the" to "follow your"
> +<p>Unfortunately, unless you keep your e-mail address to some private
> +friends, sooner or later spammer
Let's change this to "unless you keep your e-mail address only with private
friends,"
> +<p>There has been no known incident of mail virus for Mozilla, so as
Let's not have this in the help docs, because if one comes up, we will be
giving incorrect information.
> + the View menu, choose <q>Message Body As,</q> and then choose
<picky>Move the comma outside the </q>.</picky>
> + <q>Simple HTML</q> or <q>Plain Text.</q>
<picky>Move the period outside the <q></picky>
> + Also, open the View menu, and uncheck <q>Display Attachments Inline.</q></p>
Same as above.
> + option and check <q>Display Attachments Inline.</q></p>
Same as above.
> + choose <q>Preferences.</q> In
Same as above.
> + <p><a href="http://wp.netscape.com/security/basics/privacy.html?cp=sspmid#cookies">More information on cookies</a></p>
Do we really want to be linking to a Netscape website? I don't know if this is
a good idea.
> + sure this is indeed true, open the View menu, then choose <q>Preferences.</q>
The period outside the <p> thing.
> +<a href="http://www.cybernothing.org/faqs/net-abuse-faq.html">Net Abuse FAQ</a>.
This is a help menu, not a spam information center. I think that these links
are best on maybe a mozilla.org page and not in Mozilla Help.
Also, note that documentation does not need sr.
Attachment #132228 -
Flags: review-
Assignee | ||
Comment 9•21 years ago
|
||
2nd try. cvs diff works now that Neil fixed the dos-format issue.
I used .important class which conent_style.css doesn't have. We need one.
Do we need to change
/mailnews/base/resources/content/junkMail.js
/extensions/help/resources/locale/en-US/help-toc.rdf
so that the Junk Mail Controls option dialog points to "Junk Mail Controls
Options" instead of "Using Junk Mail Controls"?
If you think the extra information after "Junk Mail Controls and Filter" should
be moved out, I could put it as a separate article in start/1.4/ and link to
it.
Attachment #132228 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #132266 -
Flags: review?(rlk)
Comment 10•21 years ago
|
||
Comment on attachment 132266 [details] [diff] [review]
patch - add content to mail_help.html
> + <li><p>Click on the thread pane icon. (If you do not see it, click
You should not have a <p> tag in a <li> tag.
> + the white listing (many mail virus send bulk messages
virus should be viruses
> + Watch it catch messages that contain catch messages that
> + might contain a virus (e.g. klez)
what? catch a catch message? this is very confusing. Are there 2 definitions of
catch messages?
> + <li>
> + Make sure to correct the Junk control when it incorrectly labels
> + messages either as junk or not junk.</li>
> + </li>
The <li> tag is being closed twice.
> +<h2><a id="opt_out_junk">
let's stick to either doing <h2 id="opt_out_junk"> or <a name="opt_out_junk">.
> +<div class="boilerplate">
well, I'll let the boilerplate issue go since I'm not 100% sure what the style
is on boilerplates.
> +<a href="http://www.cybernothing.org/faqs/net-abuse-faq.html">Net Abuse FAQ</a>.
This is a help menu, not a spam information center. I think that these links
are best on maybe a mozilla.org page and not in Mozilla Help.
I know that I"m being picky but we need to stop degrading the HTML and bloat in
help.
If you fix these problems (or give an explanation as why you did not fix them),
I'll r= the next patch.
Attachment #132266 -
Flags: review?(rlk) → review-
Comment 12•21 years ago
|
||
*** Bug 221252 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•21 years ago
|
Attachment #132266 -
Attachment is obsolete: true
Assignee | ||
Comment 13•21 years ago
|
||
Since some of the stuff is not appropriate for Help, I've converted it to an
online tutorial (see bug 214845). What we could do is check in some of the text
and leave the rest as "supplementary material". Brant, care to review?
Comment 14•21 years ago
|
||
Daniel: We really should have junk mail control text in help. I just don't want
to have references to other sites and, as always, clean HTML and clear
documentation :).
Assignee | ||
Comment 15•21 years ago
|
||
Comment 16•21 years ago
|
||
hmm. After looking at that, I think that we should wait until 1.7a when the mail
help docs get split up (which they need really bad), then it might be easier to
do this.
Updated•21 years ago
|
Assignee | ||
Comment 17•21 years ago
|
||
Assignee | ||
Comment 18•21 years ago
|
||
this patch depends on the .png image fix
Assignee | ||
Updated•21 years ago
|
Attachment #138547 -
Flags: review?(rlk)
Assignee | ||
Updated•21 years ago
|
Attachment #138546 -
Flags: review?(rlk)
Assignee | ||
Comment 19•21 years ago
|
||
last patch has markup problem.
Attachment #138547 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #138547 -
Flags: review?(rlk)
Comment 20•21 years ago
|
||
Comment on attachment 138578 [details] [diff] [review]
patch rv1.1
this looks good! Do we have any TOC/index updates?
Attachment #138578 -
Flags: review+
Updated•21 years ago
|
Attachment #138546 -
Flags: review?(rlk) → review+
Updated•21 years ago
|
QA Contact: stolenclover → rlk
Comment 21•21 years ago
|
||
Fix checked in.
Also added the image to jar.mn, since the patch forgot.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 22•21 years ago
|
||
rlk, I think you checked in mail_junk_column.png as text file.
Comment 23•21 years ago
|
||
ok, that should fix it. These images are driving me nuts! I think someone needs
to make image files binary by default like the MozDev CVS server is.
Assignee | ||
Updated•21 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•