Pham Reporter
	Description • 21 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030504 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030504 Mozilla Firebird/0.6

IE has one. Maybe since people want one for Search Bar icon, they would want one
for View.

Reproducible: Always

Steps to Reproduce:
1. Go to History
2. Look at View
3.

Actual Results:  
Want to change it with keyboard(not really) but can't

Expected Results:  
Have an accesskey for it

	David Tenser [:djst]
	Comment 1 • 21 years ago

Confirming

	Simon Paquet [:sipaq]
	Comment 2 • 21 years ago

IMO this WONTFIX or INVALID. We have keyboard accelerators for all the view
options in the history sidebar. Why would we need an accelerator for View?

	Daniel Jackson
	Comment 3 • 21 years ago

"Why would we need an accelerator for View?" 
-- Well, at least on my build, I can't get to the "View" menu with just the
keyboard.

I vote to use IE's shortcut of Alt+W, that won't cause a clash as far as I can see.

	Daniel Santos
	Comment 5 • 20 years ago

Problem:  What if the HTML content in the active frame has a field that uses the
accesskey of "w" already? (.e.g. <input name="status_whiteboard" accesskey="w"
value="" size="60">).  Try ALT-W on this page and see what happens.  Oops, I'm
using 0.8 on this computer.  I hope this is the same on 0.9.3 (upgrading after
this submit! :)

	Nickolay_Ponomarev
	Comment 6 • 20 years ago

*** Bug 256233 has been marked as a duplicate of this bug. ***

	Aaron Leventhal
	Comment 7 • 20 years ago

Please put the View button in the tab order and make sure it shows focus and the
Enter key can open it. Looks like a "button with popup" control, which should
act that way.

	Aaron Leventhal
	Comment 8 • 20 years ago

What happened with this patch. Why was it never submitted for review?

	Aaron Leventhal
	Comment 9 • 20 years ago

Jeeds mnemonic key and should be in tab order

	Doron Rosenberg (IBM) Assignee
	Comment 10 • 20 years ago

aaron -  when focused, enter does not show the dropdown.  This could be
something wrong in the core.

	Aaron Leventhal
	Comment 11 • 20 years ago

(In reply to comment #10)
Whatever widget it is, the implementation in XBL must be fixed so that both
Enter and space drop down the menu.

	Aaron Leventhal
	Comment 12 • 20 years ago

Comment on attachment 174407 [details] [diff] [review]
patch - however, when focused, enter does not show the dropdown.

This should be a button, not a toolbarbutton, because it's not in the toolbar.
Toolbar buttons are not focusable.

If there is no binding yet for button type="menu" there should be.

The following 3 ways should open the dropdown:
enter, space and the accesskey.

There should definitely be an accesskey assigned,alt+W would be okay.

	neil@parkwaycc.co.uk
	Comment 14 • 20 years ago

Comment on attachment 178855 [details] [diff] [review]
patch v1

>+    <handlers>
>+      <handler event="keypress">
>+      <![CDATA[
>+        if (event.keyCode == event.DOM_VK_RETURN ||
>+            event.charCode == event.DOM_VK_SPACE) {
>+          this.open = true;
>+        }
>+      ]]>
>+      </handler>
>+    </handlers>
Two questions:
1. Why enter and space? Which native widgets are we copying?
2. Would you mind writing a separate <handler/> for each key?

	Aaron Leventhal
	Comment 15 • 20 years ago

> 1. Why enter and space? Which native widgets are we copying?
I told him to do that. Buttons that contain popups are not very common, but I
have seen them. Because they are buttons, they still are activated the way
normal buttons do: via Enter, space or the mnemomonic accesskey.

	Doron Rosenberg (IBM) Assignee
	Comment 16 • 20 years ago

In gnomestripe, we default to giving a min-width to buttons, but in the sidebar
this is ugly (causes a really short input field).  Hence the
style="min-width:0px !important;" on the button.

Also, this patch fixes menu buttons in firefox from displaying a whole column
of dropdown arrows (probably related to the min-width) by adding:
  background-repeat: no-repeat;
  background-position: center center;

	Doron Rosenberg (IBM) Assignee
	Comment 17 • 20 years ago

In gnomestripe, we default to giving a min-width to buttons, but in the sidebar
this is ugly (causes a really short input field).  Hence the
style="min-width:0px !important;" on the button.

Also, this patch fixes menu buttons in firefox from displaying a whole column
of dropdown arrows (probably related to the min-width) by adding:
  background-repeat: no-repeat;
  background-position: center center;

	Doron Rosenberg (IBM) Assignee
	Comment 18 • 20 years ago

Comment on attachment 179060 [details] [diff] [review]
with neil's nits

weird, double post somehow.

	neil@parkwaycc.co.uk
	Comment 20 • 20 years ago

Comment on attachment 179106 [details] [diff] [review]
update xpfe, use action=""

>+      <handler event="keypress" keycode="VK_RETURN" action="this.open = true"/>
>+      <handler event="keypress" key=" " action="this.open = true"/>
Nit: semicolons please.

	Doron Rosenberg (IBM) Assignee
	Comment 21 • 20 years ago

checked in.

	Steve England [:stevee]
	Comment 22 • 20 years ago

Could this patch have caused bug 288662?

	Thomas Bertels
	Comment 23 • 19 years ago

The button looks ugly since the button class is now toobarbutton.
See attachment 179296 [details] for the old look.
Isn't it possible to get it back with or without keeping the actual class ?