Closed Bug 223181 Opened 21 years ago Closed 21 years ago

[META] Bookmark rewrite cleanup

Categories

(Camino Graveyard :: Bookmarks, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino0.8

People

(Reporter: david.haas, Assigned: mikepinkerton)

References

Details

Attachments

(6 files)

I'm attaching various fixes I already have for the bookmark system here. They'll come as one big (well, not that big) patch - it should be easy to split into bite sized morsels if that's preferred.
Attached patch Export HTML/Plist patch (deleted) — — Splinter Review
This patch a) fixes the HTML export system (which is broken on 10.2, and won't even run on 10.1) and b) adds in support for exporting Safari.plist files. Beyond the new -writeSafariDictionary methods, I moved all the declarations for export/import keys into BookmarkItem.h and defined them in BookmarkItem.m.
Attached patch Startup cleanup (deleted) — — Splinter Review
This patch fixes a boo-boo on files which didn't have the toolbar flag set properly, and schmears out loading the site icons so there isn't such a delay on load.
Attached patch Bookmark Toolbar patch (deleted) — — Splinter Review
This a) fixes a crash which can occur if a bookmark folder in the toolbar is accidentally dropped into itself on a drag & drop b) Makes sure the toolbar is visible on the first window if Camino was launched to handle an apple-event c) Preserves the order of bookmarks in a folder in the event of a mass drag & drop (current behavior reverses their order).
Attached patch Bookmark Info Window patch (deleted) — — Splinter Review
This prevents titles of bookmark from overlapping the "close/minimize/maximize" buttons on the Bookmark Info panel.
Attached patch BookmarkView patch (deleted) — — Splinter Review
This a)makes sure the bookmarks are visible in the event Camino was launched via an apple-event b)pops open the search result window when you do a search, in the event it was hidden c)preserves the order of bookmarks dropped in a mass drag & drop (current behavior reverses their order in a folder) d)fixes some button states appropriately depending on what folder is selected e)gets rid of a useless method & cleans up a differnt method.
Attachment #133814 - Flags: review?
Attachment #133815 - Flags: review?
Attachment #133816 - Flags: review?
Attachment #133817 - Flags: review?
Attachment #133818 - Flags: review?
Attached patch Bookmark Icon patch (deleted) — — Splinter Review
This preserves the top 10 list, toolbar bar, etc icons in the event you change the dock menu folder.
Attachment #133819 - Flags: review?
cc sbwoodside, pushing pinkerton's e-mails from this bug today into the triple digets ;)
Personally, I'd rather see a separate bug for each one. Just easier to keep track of (but maybe not to anyone else)
I agree with simon. I will split the bug and patches and make this one a META, with all bugs created from this one in the dependency tree.
Summary: (patch) Bookmark cleanup → [META] Bookmark rewrite cleanup
Depends on: 223204
Depends on: 223205
Depends on: 223207
Depends on: 223208
Depends on: 223209
Depends on: 223210
Depends on: 223176
Depends on: 223177
Depends on: 223180
nominee for 0.8
Target Milestone: --- → Camino0.8
Which of these fixes the "add separator" button not moving?
No longer depends on: 223180
Depends on: 223413
Depends on: 223417
re comment 11: bug 223413. It's just a replacement nib.
Depends on: 223576
Depends on: 223615
Removing dependency on bug 223576. How that's related to this bug in any way is beyond me.
No longer depends on: 223576
Attachment #133814 - Flags: review?
Attachment #133815 - Flags: review?
Attachment #133816 - Flags: review?
Attachment #133817 - Flags: review?
Attachment #133818 - Flags: review?
Comment on attachment 133819 [details] [diff] [review] Bookmark Icon patch unset review requests since this is a meta bug now.
Attachment #133819 - Flags: review?
Depends on: 224629
I added dependancy on bug 224629.
Depends on: 225276
Depends on: 223700
Depends on: 223660
Depends on: 223325
Nominating bug 199790
Depends on: 199790
Depends on: 225769
Depends on: 209886
Depends on: 223315
Depends on: 170797
Depends on: 227040
Depends on: 227064
Depends on: 227016
Removing bug 225276 from the list since it has nothing to do with bookmarks.
No longer depends on: 225276
removing things we know aren't related to the bm cleanup and closing, since we're tracking the bugs individually now.
Status: NEW → RESOLVED
Closed: 21 years ago
No longer depends on: 223325, 224629
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: