Closed
Bug 223181
Opened 21 years ago
Closed 21 years ago
[META] Bookmark rewrite cleanup
Categories
(Camino Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino0.8
People
(Reporter: david.haas, Assigned: mikepinkerton)
References
Details
Attachments
(6 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
I'm attaching various fixes I already have for the bookmark system here.
They'll come as one big (well, not that big) patch - it should be easy to split
into bite sized morsels if that's preferred.
Reporter | ||
Comment 1•21 years ago
|
||
This patch a) fixes the HTML export system (which is broken on 10.2, and won't
even run on 10.1) and b) adds in support for exporting Safari.plist files.
Beyond the new -writeSafariDictionary methods, I moved all the declarations for
export/import keys into BookmarkItem.h and defined them in BookmarkItem.m.
Reporter | ||
Comment 2•21 years ago
|
||
This patch fixes a boo-boo on files which didn't have the toolbar flag set
properly, and schmears out loading the site icons so there isn't such a delay
on load.
Reporter | ||
Comment 3•21 years ago
|
||
This a) fixes a crash which can occur if a bookmark folder in the toolbar is
accidentally dropped into itself on a drag & drop
b) Makes sure the toolbar is visible on the first window if Camino was launched
to handle an apple-event
c) Preserves the order of bookmarks in a folder in the event of a mass drag &
drop (current behavior reverses their order).
Reporter | ||
Comment 4•21 years ago
|
||
This prevents titles of bookmark from overlapping the "close/minimize/maximize"
buttons on the Bookmark Info panel.
Reporter | ||
Comment 5•21 years ago
|
||
This
a)makes sure the bookmarks are visible in the event Camino was launched via an
apple-event
b)pops open the search result window when you do a search, in the event it was
hidden
c)preserves the order of bookmarks dropped in a mass drag & drop (current
behavior reverses their order in a folder)
d)fixes some button states appropriately depending on what folder is selected
e)gets rid of a useless method & cleans up a differnt method.
Reporter | ||
Updated•21 years ago
|
Attachment #133814 -
Flags: review?
Reporter | ||
Updated•21 years ago
|
Attachment #133815 -
Flags: review?
Reporter | ||
Updated•21 years ago
|
Attachment #133816 -
Flags: review?
Reporter | ||
Updated•21 years ago
|
Attachment #133817 -
Flags: review?
Reporter | ||
Updated•21 years ago
|
Attachment #133818 -
Flags: review?
Reporter | ||
Comment 6•21 years ago
|
||
This preserves the top 10 list, toolbar bar, etc icons in the event you change
the dock menu folder.
Reporter | ||
Updated•21 years ago
|
Attachment #133819 -
Flags: review?
Reporter | ||
Comment 7•21 years ago
|
||
cc sbwoodside, pushing pinkerton's e-mails from this bug today into the triple
digets ;)
Comment 8•21 years ago
|
||
Personally, I'd rather see a separate bug for each one. Just easier to keep
track of (but maybe not to anyone else)
Comment 9•21 years ago
|
||
I agree with simon. I will split the bug and patches and make this one a META,
with all bugs created from this one in the dependency tree.
Updated•21 years ago
|
Summary: (patch) Bookmark cleanup → [META] Bookmark rewrite cleanup
Comment 11•21 years ago
|
||
Which of these fixes the "add separator" button not moving?
Reporter | ||
Comment 12•21 years ago
|
||
re comment 11: bug 223413. It's just a replacement nib.
Comment 13•21 years ago
|
||
Removing dependency on bug 223576. How that's related to this bug in any way is
beyond me.
No longer depends on: 223576
Updated•21 years ago
|
Attachment #133814 -
Flags: review?
Updated•21 years ago
|
Attachment #133815 -
Flags: review?
Updated•21 years ago
|
Attachment #133816 -
Flags: review?
Updated•21 years ago
|
Attachment #133817 -
Flags: review?
Updated•21 years ago
|
Attachment #133818 -
Flags: review?
Comment 14•21 years ago
|
||
Comment on attachment 133819 [details] [diff] [review]
Bookmark Icon patch
unset review requests since this is a meta bug now.
Attachment #133819 -
Flags: review?
Comment 15•21 years ago
|
||
I added dependancy on bug 224629.
Comment 16•21 years ago
|
||
Nominating bug 199790
Comment 17•21 years ago
|
||
Removing bug 225276 from the list since it has nothing to do with bookmarks.
No longer depends on: 225276
Assignee | ||
Comment 18•21 years ago
|
||
removing things we know aren't related to the bm cleanup and closing, since
we're tracking the bugs individually now.
You need to log in
before you can comment on or make changes to this bug.
Description
•