Closed
Bug 223208
Opened 21 years ago
Closed 21 years ago
[patch] New bookmark manager info panel fixes
Categories
(Camino Graveyard :: Bookmarks, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
Camino0.8
People
(Reporter: Usul, Assigned: mikepinkerton)
References
Details
Attachments
(1 file)
(deleted),
patch
|
sbwoodside
:
review-
|
Details | Diff | Splinter Review |
This prevents titles of bookmark from overlapping the "close/minimize/maximize"
buttons on the Bookmark Info panel.
Reporter | ||
Comment 1•21 years ago
|
||
Comment 2•21 years ago
|
||
Doesn't work. Try entering all M's (capital "M" is the widest character, hence
the name "em dash") for a title. I think this is a cocoa bug, is it fixed in
panther?
Updated•21 years ago
|
Attachment #133832 -
Flags: review-
Comment 4•21 years ago
|
||
recommend close as WFM.
Assignee | ||
Comment 5•21 years ago
|
||
wait, what about the patch?
Comment 6•21 years ago
|
||
I guess that it would still help on 10.{1,2}. But the proposed patch isn't a
good solution, since a name of 43 "M"s will still overrun the buttons. I guess
it could be better to reduce the length to whatever number of "M"s will not
overrun. ideally it should measure the width of the string in question though.
Assignee | ||
Updated•21 years ago
|
Target Milestone: --- → Camino0.8
Assignee | ||
Comment 7•21 years ago
|
||
would a shorter max fix it? if it's simple to fix on 10.1/2, then why not? How
about 40? That should be MORE than plenty, eh?
Comment 8•21 years ago
|
||
I think that "M" is usually the widest character. So anything less than 43
characters would be a workaround.
Reporter | ||
Comment 9•21 years ago
|
||
Mike would you commit a Max at 40 ?
Reporter | ||
Comment 10•21 years ago
|
||
Comment on attachment 133832 [details] [diff] [review]
david's patch
Mike Could you check this one with a value of 40 ?
Attachment #133832 -
Flags: superreview?(pinkerton)
Assignee | ||
Comment 11•21 years ago
|
||
so with a string of all 'M's, the best i can get is 25 characters to not
overflow. not even sure how that localizes to say, japanese. and 25 characters
isn't really all that much for strings that aren't all 'M'.
why not just allow the window to resize and chalk it up to an os bug?
Reporter | ||
Updated•21 years ago
|
Attachment #133832 -
Flags: superreview?(pinkerton)
Assignee | ||
Comment 12•21 years ago
|
||
not going to fix this. workaround: resize the window.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•